[User Model] [Fix] Notification Open & Confirm Delivery REST API calls failing

[jkasten2]

Description

1 Line Summary

Notification Open & Confirm Delivery REST API calls were failing due to placeholder player_id being used.

Details

CoreModuleDirector was introduced in v16, and is the place to access the pushSubscriptionId we needed. However CoreModuleDirector does not work in the ServiceWorker context since it uses JS APIs that are not available. This includes localStorage (possibly switch to indexDB in the future) as well as access to window and possibly others. Give the scope of such changes would large and has unknowns to address CoreModuleDirector we added a ModelCacheDirectAccess class to directly access what we needed, on the trade off it duplicates some code.

Validation

Tests

Tested on Chrome on Windows 11. Ensure both notification open and confirm deliveries show on the dashboard.

Info

Checklist

• All the automated tests pass or I explained why that is not possible
• I have personally tested this on my machine or explained why that is not possible
• I have included test coverage for these changes or explained why they are not needed

Programming Checklist
Interfaces:

• Don't use default export
• New interfaces are in model files

Functions:

• Don't use default export
• All function signatures have return types
• Helpers should not access any data but rather be given the data to operate on.

Typescript:

• No Typescript warnings
• Avoid silencing null/undefined warnings with the exclamation point

Other:

• Iteration: refrain from using elem of array syntax. Prefer forEach or use map
• Avoid using global OneSignal accessor for context if possible. Instead, we can pass it to function/constructor so that we don't call OneSignal.context

Screenshots

Info

Checklist

• I have included screenshots/recordings of the intended results or explained why they are not needed

---

Related Tickets

---

---

This change is 

[emawby]

Do we know why CoreModuleDirector doesn't work in the SW context?

[jkasten2]

Do we know why CoreModuleDirector doesn't work in the SW context?

That is a good question, I updated my PR details with an answer to this.