Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update min requirements from Android 5 to Android 7 #774

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

shepherd-l
Copy link
Contributor

@shepherd-l shepherd-l commented Jan 2, 2025

Description

One Line Summary

Update min requirements from Android 5 to Android 7

Details

Motivation

ClassNotFoundException: java.util.function.Consumer error in Android 5 and 6 from the Unity SDK's java bridge.

There doesn't look to be a straightforward way to support/workaround the java.util.function.Consumer class in Unity for Android 5 and 6. And since these Android versions are pretty old with around 2.3% global usage and will eventually be unsupported - we've decided to bump the minimum Android version of the Unity SDK to Android 7 where java.util.function.Consumer is supported.

Affected code checklist

  • Notifications
    • Display
    • Open
    • Push Processing
    • Confirm Deliveries
  • Outcomes
  • Sessions
  • In-App Messaging
  • REST API requests
  • Public API changes

Checklist

Overview

  • I have filled out all REQUIRED sections above
  • PR does one thing
    • If it is hard to explain how any codes changes are related to each other then it most likely needs to be more than one PR
  • Any Public API changes are explained in the PR details and conform to existing APIs

Testing

  • I have included test coverage for these changes, or explained why they are not needed
  • All automated tests pass, or I explained why that is not possible
  • I have personally tested this on my device, or explained why that is not possible

Final pass

  • Code is as readable as possible.
    • Simplify with less code, followed by splitting up code into well named functions and variables, followed by adding comments to the code.
  • I have reviewed this PR myself, ensuring it meets each checklist item
    • WIP (Work In Progress) is ok, but explain what is still in progress and what you would like feedback on. Start the PR title with "WIP" to indicate this.

This change is Reviewable

@nan-li
Copy link

nan-li commented Jan 3, 2025

Do you have any stats (industry wide or OneSignal user base) to include in this PR about the prevalence of Android 5 and 6 to reinforce the version deprecation?

@shepherd-l
Copy link
Contributor Author

shepherd-l commented Jan 3, 2025

Good question

Saw that Android 5 and Android 6 have about a 2.3% global usage, I'll clarify it in the PR description

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants