Yashwanth individual permission change show #2868

yashwanth170 · 2024-11-14T01:13:46Z

Description

The permission change log table only logs changes made to role, so I have added additional features to log permission changes made to individual account. Now the table shows latest logs of changes made to both individual and role

Related PRS (if any):

This frontend PR is related to the #1149 backend PR.
To test this frontend PR you need to checkout the 'Yashwanth_individual_permission_change_show_backend' Backend PR.
…

Main changes explained:

When changes are made to indvidual or user, the function calls endpoint POST_USER_PERMISSION_CHANGE_LOGS to post changes made to permissions
Created new endpoint GET_USER_PERMISSION_CHANGE_LOGS to fetch changes made to both individual and role

How to test:

check into current branch, and check into backend branch Yashwanth_individual_permission_change_show_backend
do npm install and ... to run this PR locally
Clear site data/cache
log as admin user
go to dashboard→ Other Links → Permission Management → Make changes to a role or individual and verify that the table updates accordingly

Screenshots or videos of changes:

Note:

Test it across different user types, and let me know if I missed any expected conventions or if you have any other suggestions.

netlify · 2024-11-14T01:14:01Z

✅ Deploy Preview for highestgoodnetwork-dev ready!

Name	Link
🔨 Latest commit	`3df8692`
🔍 Latest deploy log	https://app.netlify.com/sites/highestgoodnetwork-dev/deploys/673fb03350f0a700080ca3b9
😎 Deploy Preview	https://deploy-preview-2868--highestgoodnetwork-dev.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

manikittu810

Hello @yashwanth170
I have tested this , and it is displaying the text Loading for a long time instead of a table and I hjave also tried using clearing the cache.

Thank you.

yashwanth170 · 2024-11-15T16:03:49Z

Hello @yashwanth170 I have tested this , and it is displaying the text Loading for a long time instead of a table and I hjave also tried using clearing the cache.

Thank you.

Hello,
Did you checkout the backend branch as well?

nathanah

Most of this logic should be on the backend. The only frontend changes required should be accommodating the new info in the permissionChangeLogTable.

nathanah · 2024-11-16T03:05:57Z

src/components/PermissionsManagement/UserPermissionsPopUp.jsx

@@ -94,6 +135,7 @@ function UserPermissionsPopUp({
            autoClose: 10000,
          });
          setToastShown(true);
+          logPermissionChanges(logPermissionChangesUrl, permissionChangeLog);


Suggested change

logPermissionChanges(logPermissionChangesUrl, permissionChangeLog);

This is not atomic. This request could fail after the permission change request succeeds, so it wouldn't show up in the history. If a dev wanted to test updating permissions manually with something like Postman, they could avoid also logging those changes which could cause confusion or potential problems.
Logging permission changes should be part of the same API call as updating the user's permissions.

nathanah · 2024-11-16T03:06:26Z

src/utils/URL.js

@@ -5,6 +5,8 @@ const APIEndpoint =
 export const ENDPOINTS = {
  APIEndpoint: () => APIEndpoint,
  USER_PROFILE: userId => `${APIEndpoint}/userprofile/${userId}`,
+  POST_USER_PERMISSION_CHANGE_LOGS: `${APIEndpoint}/logPermissionChanges`,


Suggested change

POST_USER_PERMISSION_CHANGE_LOGS: `${APIEndpoint}/logPermissionChanges`,

nathanah · 2024-11-16T03:07:08Z

src/components/PermissionsManagement/UserPermissionsPopUp.jsx

+    let existingPermissions = allUserInfo.permissions?.frontPermissions || [];
+    const existingPermissionsSet = new Set(existingPermissions || []);
+    const newPermissionsSet = new Set(userPermissions || []);
+    const addedPermissions = (userPermissions || []).filter(
+      permission => !existingPermissionsSet.has(permission),
+    );
+    const removedPermissions = (existingPermissions || []).filter(
+      permission => !newPermissionsSet.has(permission),
+    );
+
+    existingPermissions = [
+      ...existingPermissions.filter(permission => !removedPermissions.includes(permission)),
+      ...addedPermissions,
+    ];
+
+    const permissionChangeLog = {
+      actualUserProfile: {
+        firstName: actualUserProfile.firstName,
+        lastName: actualUserProfile.lastName,
+      },
+      authUser: {
+        email: authUser.email,
+        role: authUser.role,
+      },
+      userId,
+      existingPermissions, // Existing permissions before change
+      addedPermissions, // New permissions added
+      removedPermissions, // Permissions removed
+    };
+


Suggested change

let existingPermissions = allUserInfo.permissions?.frontPermissions || [];

const existingPermissionsSet = new Set(existingPermissions || []);

const newPermissionsSet = new Set(userPermissions || []);

const addedPermissions = (userPermissions || []).filter(

permission => !existingPermissionsSet.has(permission),

);

const removedPermissions = (existingPermissions || []).filter(

permission => !newPermissionsSet.has(permission),

);

existingPermissions = [

...existingPermissions.filter(permission => !removedPermissions.includes(permission)),

...addedPermissions,

];

const permissionChangeLog = {

actualUserProfile: {

firstName: actualUserProfile.firstName,

lastName: actualUserProfile.lastName,

},

authUser: {

email: authUser.email,

role: authUser.role,

},

userId,

existingPermissions, // Existing permissions before change

addedPermissions, // New permissions added

removedPermissions, // Permissions removed

};

This logic should be on the backend and part of the same API call as the update itself.

nathanah · 2024-11-16T03:07:18Z

src/components/PermissionsManagement/UserPermissionsPopUp.jsx

@@ -80,9 +90,40 @@ function UserPermissionsPopUp({
    const userId = actualUserProfile?._id;

    const url = ENDPOINTS.USER_PROFILE(userId);
+    const logPermissionChangesUrl = ENDPOINTS.POST_USER_PERMISSION_CHANGE_LOGS;


Suggested change

const logPermissionChangesUrl = ENDPOINTS.POST_USER_PERMISSION_CHANGE_LOGS;

nathanah · 2024-11-16T03:07:34Z

src/components/PermissionsManagement/UserPermissionsPopUp.jsx

+  const logPermissionChanges = async (logPermissionChangesUrl, permissionChangeLog) => {
+    try {
+      await axios.post(logPermissionChangesUrl, permissionChangeLog);
+    } catch (error) {
+      toast.error('Error logging permissions:', {
+        autoClose: 10000,
+      });
+    }
+  };
+


Suggested change

const logPermissionChanges = async (logPermissionChangesUrl, permissionChangeLog) => {

try {

await axios.post(logPermissionChangesUrl, permissionChangeLog);

} catch (error) {

toast.error('Error logging permissions:', {

autoClose: 10000,

});

}

};

nathanah · 2024-11-16T03:09:14Z

src/components/PermissionsManagement/PermissionsManagement.jsx

@@ -243,7 +244,7 @@ function PermissionsManagement({ roles, auth, getUserRole, userProfile, darkMode
      </div>
      {loading && <p className="loading-message">Loading...</p>}
      {changeLogs?.length > 0 && (
-        <PermissionChangeLogTable changeLogs={changeLogs.slice().reverse()} darkMode={darkMode} />
+        <PermissionChangeLogTable changeLogs={changeLogs} darkMode={darkMode} />


removing reverse? Nvm I see the sort on the backend now.

audreydieuanh

The table doesn't show, and I have done git checkout for backend PR #1149.

…ighestGoodNetworkApp into Yashwanth_individual_permission_change_show

yashwanth170 added 2 commits November 9, 2024 11:29

Yashwanth Permission Log Table

ce7ecd8

fix:Changing Column name

3379eb7

yashwanth170 added the High Priority - Please Review First This is an important PR we'd like to get merged as soon as possible label Nov 14, 2024

manikittu810 reviewed Nov 15, 2024

View reviewed changes

nathanah requested changes Nov 16, 2024

View reviewed changes

audreydieuanh requested changes Nov 16, 2024

View reviewed changes

yashwanth170 added 3 commits November 20, 2024 18:33

Merge branch 'development' of https://github.com/OneCommunityGlobal/H…

9940a72

…ighestGoodNetworkApp into Yashwanth_individual_permission_change_show

Merge branch 'development' of https://github.com/OneCommunityGlobal/H…

10869e5

…ighestGoodNetworkApp into Yashwanth_individual_permission_change_show

fix:Moved logic to backend

3df8692

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Yashwanth individual permission change show #2868

Yashwanth individual permission change show #2868

yashwanth170 commented Nov 14, 2024 •

edited

Loading

netlify bot commented Nov 14, 2024 •

edited

Loading

manikittu810 left a comment

yashwanth170 commented Nov 15, 2024

nathanah left a comment

nathanah Nov 16, 2024

nathanah Nov 16, 2024

nathanah Nov 16, 2024

nathanah Nov 16, 2024

nathanah Nov 16, 2024

nathanah Nov 16, 2024 •

edited

Loading

audreydieuanh left a comment

Yashwanth individual permission change show #2868

Are you sure you want to change the base?

Yashwanth individual permission change show #2868

Conversation

yashwanth170 commented Nov 14, 2024 • edited Loading

Description

Related PRS (if any):

Main changes explained:

How to test:

Screenshots or videos of changes:

Note:

netlify bot commented Nov 14, 2024 • edited Loading

✅ Deploy Preview for highestgoodnetwork-dev ready!

manikittu810 left a comment

Choose a reason for hiding this comment

yashwanth170 commented Nov 15, 2024

nathanah left a comment

Choose a reason for hiding this comment

nathanah Nov 16, 2024

Choose a reason for hiding this comment

nathanah Nov 16, 2024

Choose a reason for hiding this comment

nathanah Nov 16, 2024

Choose a reason for hiding this comment

nathanah Nov 16, 2024

Choose a reason for hiding this comment

nathanah Nov 16, 2024

Choose a reason for hiding this comment

nathanah Nov 16, 2024 • edited Loading

Choose a reason for hiding this comment

audreydieuanh left a comment

Choose a reason for hiding this comment

yashwanth170 commented Nov 14, 2024 •

edited

Loading

netlify bot commented Nov 14, 2024 •

edited

Loading

nathanah Nov 16, 2024 •

edited

Loading