Skip to content
This repository has been archived by the owner on May 2, 2024. It is now read-only.

Fix: IP Address Validation #4

Merged
merged 4 commits into from
Aug 3, 2023
Merged

Fix: IP Address Validation #4

merged 4 commits into from
Aug 3, 2023

Conversation

Lilit0x
Copy link
Contributor

@Lilit0x Lilit0x commented Aug 3, 2023

This PR aims to fix two bugs.

  • The current bug with IP address validation that prevents scs from sharing/receiving items.
    The image below shows the error.
    This issue happens because sometimes, an Incoming Message Event is not emitted before a connection is established. And since the connection_id is being set when this event occurs, during validation, the id can't be found because that event was not emitted.
    Registering a connection_id has been moved to after the connection has been established.

image

  • Secondly, the npm bin package was not changed to reflect the new name scs

@Lilit0x Lilit0x requested a review from dantelex August 3, 2023 06:10
@codecov
Copy link

codecov bot commented Aug 3, 2023

Codecov Report

Merging #4 (5a6d5ed) into main (1ba0632) will decrease coverage by 0.54%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main       #4      +/-   ##
==========================================
- Coverage   66.70%   66.16%   -0.54%     
==========================================
  Files          11       11              
  Lines         997     1005       +8     
==========================================
  Hits          665      665              
- Misses        332      340       +8     
Files Changed Coverage Δ
share/src/main.rs 0.00% <ø> (ø)
share/src/network/hole_puncher.rs 0.00% <0.00%> (ø)

@Lilit0x Lilit0x merged commit 9996f01 into main Aug 3, 2023
12 of 14 checks passed
@Lilit0x Lilit0x deleted the fix/whitelists branch August 3, 2023 06:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants