Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: sync languages including a dash #22

Merged
merged 2 commits into from
Jun 16, 2023
Merged

fix: sync languages including a dash #22

merged 2 commits into from
Jun 16, 2023

Conversation

decodekult
Copy link
Collaborator

Use a proper tokenizer for the post-lang field.

Ref: wpmlbridge-263

@decodekult
fix: sync languages including a dash
3570d94 
Use a proper tokenized for the post-lang field.
@decodekult decodekult mentioned this pull request Jun 16, 2023
Closed
@decodekult decodekult linked an issue Jun 16, 2023 that may be closed by this pull request
No results on searches for languages with codes including a dash #21
Closed
@decodekult decodekult requested a review from a team June 16, 2023 08:29
dgwatkins
dgwatkins requested changes Jun 16, 2023
View reviewed changes
Copy link
Collaborator

@dgwatkins dgwatkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good but you need to fix those unit tests.

dgwatkins
dgwatkins approved these changes Jun 16, 2023
View reviewed changes
Copy link
Collaborator

@dgwatkins dgwatkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 @decodekult

@decodekult decodekult merged commit b7f57c9 into master Jun 16, 2023
@decodekult decodekult deleted the wpmlbridge-263 branch June 16, 2023 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgwatkins dgwatkins dgwatkins approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

No results on searches for languages with codes including a dash
2 participants
@decodekult @dgwatkins