Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix]: 월별 통계 로직 수정 #69

Merged
merged 2 commits into from
Feb 8, 2024
Merged

[fix]: 월별 통계 로직 수정 #69

merged 2 commits into from
Feb 8, 2024

Conversation

threeony
Copy link
Contributor

@threeony threeony commented Feb 8, 2024

PULL REQUEST

🎋 작업중인 브랜치

💡 작업동기

  • 월별 통계 로직 수정

🔑 주요 변경사항

  • 회고 null체크 -> 공백 체크

💡 관련 이슈

  • 관련 이슈를 입력해주세요.

@threeony threeony added the 🐛 fix 버그 수정 label Feb 8, 2024
@threeony threeony self-assigned this Feb 8, 2024
@threeony threeony linked an issue Feb 8, 2024 that may be closed by this pull request
1 task
Copy link
Contributor

@kimjm9841 kimjm9841 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다~!

@@ -91,18 +91,22 @@ public StatsResponseDTO.MonthDTO getMonthStats(LocalDate date){

if(memoir.getEmoticon() != null){
rate++;
System.out.println(memoir.getId());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

혹시 출력문은 디버깅 용도인가용?

Copy link
Contributor

@realisshomyang realisshomyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@threeony threeony merged commit 47c93f7 into dev Feb 8, 2024
@threeony threeony deleted the fix/#67 branch February 8, 2024 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 fix 버그 수정
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[fix]: 월별 통계 로직 변경
3 participants