Fix span used to determine whether signature help should be shown #436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Need rebase on latest dev. Travis build failures are fixed recently. |
OmniSharp used the full span of an argument list to determine whether signature help should be shown. However, that includes both leading and trailing trivia, which means that it would return signatures for positions outside of the argument list. In addition, I switched it to use `Contains(...)` rather than `IntersectsWith(...)` since checking the position against the argument list span should not include the outer positions (e.g. on the left or right of the parentheses).
DustinCampbell
force-pushed
the
fix-signature-help-span
branch
from
0614c5e to
ee17829
Compare
|
rebased |
|
Cool. Passes now. Anyone else want to take a look? |
|
|
@filipw -- huh? I totally just rebased against dev |
|
Trying again |
|
@DustinCampbell that was me... I merge something else, but it shouldn't have been a conflict. Sorry. 🐑 |
|
no worries. It really wasn't a conflict. 😄 |
|
No github is just a little more aggressive with it's merge policy. |
filipw
added a commit
that referenced
this pull request
Mar 21, 2016
Fix span used to determine whether signature help should be shown
|
great 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OmniSharp used the full span of an argument list to determine whether signature help should be shown. However, that includes both leading and trailing trivia, which means that it would return signatures for positions outside of the argument list. In addition, I switched it to use
Contains(...)rather thanIntersectsWith(...)since checking the position against the argument list span should not include the outer positions (e.g. on the left or right of the parentheses).This fixes dotnet/vscode-csharp#64.
cc @david-driscoll, @troydai