-
Notifications
You must be signed in to change notification settings - Fork 419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for Roslyn rename options #1495
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rchande
approved these changes
Jun 3, 2019
bjorkstromm
approved these changes
Jun 3, 2019
since this was approved I will merge it - I will have a separate PR soon touching similar code and don't want to get into conflicts and keep this open |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces support (via
omnisharp.json
and the rest of OmniSharp configuration model) for Roslyn renaming options.The solutions builds upon the original workspace options extensibility created for
FormattingOptions
. The options are respected in real time - changes are propagated to the workspace without the need to restart OmniSharp.Following options are supported (all of them are switched off by default and need to be enabled explicitly):
RenameOverloads
RenameInComments
RenameInStrings
I will update the documentation https://github.com/OmniSharp/omnisharp-roslyn/wiki/Configuration-Options once this is merged.