Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pinned gitversion #1278

Merged
merged 2 commits into from
Aug 28, 2018
Merged

pinned gitversion #1278

merged 2 commits into from
Aug 28, 2018

Conversation

david-driscoll
Copy link
Member

cc @rchande @akshita31 @mholo65 @gep13

@rchande
Copy link

rchande commented Aug 28, 2018

@david-driscoll How are you planning to validate that this worked?

@DustinCampbell
Copy link
Contributor

Does this fix #1202?

@bjorkstromm
Copy link
Member

bjorkstromm commented Aug 28, 2018

@rchande you can see here and here that it works.

Copy link
Member

@bjorkstromm bjorkstromm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@rchande
Copy link

rchande commented Aug 28, 2018

@mholo65 Thanks!

@david-driscoll david-driscoll merged commit 31c8464 into master Aug 28, 2018
@akshita31 akshita31 deleted the fix/pin-gv branch August 28, 2018 23:38
@akshita31
Copy link
Contributor

@DustinCampbell I tried today with the latest master and #1202 isn't fixed by this change.

@gep13
Copy link

gep13 commented Sep 12, 2018

@akshita31 can you please confirm, by looking in the tools folder, what version of GitVersion is installed in that folder? You should be able to right click on the exe, and select Properties, then find the version number in the details tab.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants