Skip to content
This repository has been archived by the owner on Feb 13, 2019. It is now read-only.

Html static page template markup update #20

Closed
peterblazejewicz opened this issue Dec 26, 2014 · 3 comments
Closed

Html static page template markup update #20

peterblazejewicz opened this issue Dec 26, 2014 · 3 comments
Labels
approved completed enhancement help wanted

Comments

@peterblazejewicz
Copy link
Member

I understand that generator template have to follow markup generated by #VisualStudio templates #15 (comment), but can some attributes be added as this tool is used outside of #VisualStudio? Like "lang", etc.

<html lang="">
<meta http-equiv="X-UA-Compatible" content="IE=edge">
<meta name="description" content="">
<meta name="viewport" content="width=device-width, initial-scale=1">

https://github.com/h5bp/html5-boilerplate/blob/master/src/index.html
@peterblazejewicz
Copy link
Member Author

This also applies to MVC template layout:
https://github.com/OmniSharp/generator-aspnet/blob/master/samples/mvc/Views/Shared/_Layout.cshtml

As MVC templates use @bootstrap - the problem is more important as templates' markup won't pass bootlint check: https://github.com/twbs/bootlint (that is: generator ships with not exactly perfect @bootstrap templates)

@sayedihashimi
Copy link
Member

@peterblazejewicz the template content doesn't have to match VS exactly.

Regarding the suggestions they all sound good to me. I think that VS should likely consider them as well so I'm adding @rustd who owns the content of those templates.

@peterblazejewicz if you send a PR with the changes I'll merge them. Also I can add you to the team since you seem to be passionate about this :)

@peterblazejewicz
Copy link
Member Author

@sayedihashimi consider done about PR (on its way).

Yes, it will be a pleasure to me to be a part of this project (I'm using C#/MVC at work) if you decide so!
Thanks!

sayedihashimi added a commit that referenced this issue Dec 30, 2014
@sayedihashimi
Merge pull request #28 from peterblazejewicz/refactor/markup
59266bf 
Update html templates markup to follow h5bp. Closes #20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
approved completed enhancement help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@peterblazejewicz @sayedihashimi