adding time support, improved tests in datatime_expressions.rs, fixed…

… scalar doc example
Omega359 · Feb 9, 2024 · 806c6ff · 806c6ff
1 parent dbbaded
commit 806c6ff
Show file tree

Hide file tree

Showing 6 changed files with 243 additions and 316 deletions.
diff --git a/datafusion-examples/examples/to_char.rs b/datafusion-examples/examples/to_char.rs
@@ -26,7 +26,7 @@ use std::sync::Arc;
 
 /// This example demonstrates how to use the to_char function via sql
 ///
-/// This function accepts date, timestamp and duration values
+/// This function accepts date, time, timestamp and duration values
 /// in the first argument and string values for the second
 #[tokio::main]
 async fn main() -> Result<()> {

diff --git a/datafusion/expr/src/built_in_function.rs b/datafusion/expr/src/built_in_function.rs
@@ -1074,6 +1074,10 @@ impl BuiltinScalarFunction {
                 vec![
                     Exact(vec![Date32, Utf8]),
                     Exact(vec![Date64, Utf8]),
+                    Exact(vec![Time32(Millisecond), Utf8]),
+                    Exact(vec![Time32(Second), Utf8]),
+                    Exact(vec![Time64(Microsecond), Utf8]),
+                    Exact(vec![Time64(Nanosecond), Utf8]),
                     Exact(vec![Timestamp(Second, None), Utf8]),
                     Exact(vec![
                         Timestamp(Second, Some(TIMEZONE_WILDCARD.into())),

diff --git a/datafusion/expr/src/expr_fn.rs b/datafusion/expr/src/expr_fn.rs
@@ -900,7 +900,7 @@ scalar_expr!(
     ToChar,
     to_char,
     datetime format,
-    "converts a date, timestamp or duration to a string based on the provided format"
+    "converts a date, time, timestamp or duration to a string based on the provided format"
 );
 nary_scalar_expr!(
     ToTimestamp,