Users without 4K permissions can request 4K movies #4957
Labels
Comments
|
Hi! |
|
The "Request 4K" button is always displayed at the moment, regardless of the user's permission. However, the request should fail with a permission error and the user should see an error message if they're not allowed. In your case, the request is still processed because the user has "auto approve" role, which bypasses the 4K request role. |
|
Yeah you are probably right |
|
Yes, We need an Auto Approve 4K |
sephrat
added a commit
to sephrat/Ombi
that referenced
this issue
Jul 14, 2023
Legacy "Auto Approve" role now only applies to non-4K requests Fixes Ombi-app#4957
tidusjar
pushed a commit
that referenced
this issue
Jul 14, 2023
Legacy "Auto Approve" role now only applies to non-4K requests Fixes #4957
tidusjar
added a commit
that referenced
this issue
Jul 14, 2023
Legacy "Auto Approve" role now only applies to non-4K requests Fixes #4957 Co-authored-by: sephrat <[email protected]>
tidusjar
added a commit
that referenced
this issue
Jul 22, 2024
Co-authored-by: tidusjar <[email protected]> Co-authored-by: sephrat <[email protected]> Co-authored-by: Conventional Changelog Action <[email protected]> Co-authored-by: Teifun2 <[email protected]> Co-authored-by: contrib-readme-bot <[email protected]> Co-authored-by: dr3amer <[email protected]> Co-authored-by: echel0n <[email protected]> Co-authored-by: Marley <[email protected]> Co-authored-by: Igor Borges <[email protected]> Co-authored-by: Lucane <[email protected]> Co-authored-by: mkgeeky <[email protected]> Co-authored-by: Miguel A Vico Moya <[email protected]> Co-authored-by: Hadrien <[email protected]> Co-authored-by: Victor Usoltsev <[email protected]> Co-authored-by: Wesley King <[email protected]> Co-authored-by: Lea <[email protected]> Co-authored-by: snyk-bot <[email protected]> Co-authored-by: snyk-bot <[email protected]> [skip ci] Co-authored-by: Jamie <[email protected]> Co-authored-by: Drew <[email protected]> [skip ci] Co-authored-by: ryan-c44 <[email protected]> Co-authored-by: Alexander Russell <[email protected]> Co-authored-by: Grygon <[email protected]> Co-authored-by: phildups7 <[email protected]> Co-authored-by: Avi <[email protected]> Co-authored-by: Antonin <[email protected]> Co-authored-by: Drew <[email protected]> Co-authored-by: Joel Samson <[email protected]> Co-authored-by: David Benson <[email protected]> fix: Consistently reset loading flag when requesting movies on discover page. (#4777) fix(sonarr): 🐛 Fixed an issue where the language list didn't correctly load for power users in the advanced options #4782 fix: Only log error messages from Microsoft (#4787) fix(notifications): Fixed the Partially TV notifications going to the admin #4797 (#4799) fix(translations): 🌐 New translations from Crowdin [skip ci] (#4801) fix(sonarr): 🐛 Sonarr V4 should work now (#4810) fixed (#4833) fix(plex-watchlist): Lookup the ID from different sources when Plex doesn't contain the metadata (#4843) fix(#4847): Invalid Discord request fixed, also fixed an issue where App Only users would not show as logged in on the user management page (#4848) fix(discover): 🐛 Fixed the default poster not taking into account the base url in some scenarios #4845 fix(wizard): 🐛 Stop access to the wizard when you have already setup ombi (#4866) fix(plex-oauth): 🐛 Fixed an issue where using OAuth you could log in as a Ombi Local user #4835 fix: Some minor tweaks to the movie info panel (#4883) fix(sonarr): 🐛 Stop the sonarr version endpoint from breaking when Sonarr is down #4895 fix: Support duplicates in Emby/JF collections (#4902) fix(discover): Fix denied requests displayed as approved (#4901) fix: Fix denied movie shown as 'processing request' in details view (#4900) fix(#4906): 🐛 Fixed an issue with power users and permissions fix: Cron Validation (#4842) fix(lidarr): Change monitor to Existing to properly add artist #3597 fix(API): Allow RequestOnBehalf rights if requested from the API (#4919) Fixes #4610 fix: added media type tag to media type text (#4638) fix(sickrage): Fixed issue with incorrect handling of SiCKRAGE episode results returned during episode status changes, now expects array of objects from data path if present (#4648) fix: Missing Poster broken link fix (#4637) fix: Improve Swagger documentation (#4652) fix(API): Fix pagination in some edge cases (#4649) fix(discover): Carousel touch not working when scrolling page and recommendations and similar movie navigation (#4633) fix: 🐛 Fixed the Request on Behalf of having blanks (#4667) fix(images): Retry images with a backoff when we get a Too Many requests from TheMovieDb #4685 fix: Landing and Login page improvements (#4690) fix(discover): 🐛 Created new Image component to handle 429's from TMDB (#4698) and fixed #4635 (#4699) fix: Override Sonarr V3 Profiles endpoint (#4678) fix(4K) :4K request fixes (#4702) fix(translations): 🌐 New translations from Crowdin [skip ci] (#4713) fix: fixed trakt image not loading when base url present (#4711) fix: 🐛 Fixed missing externals (#4712) fix: Log Microsoft warnings to log file (#4723) fix: Localize recently requested on discover page (#4729) Fix: Ombi.Api.Lidarr: Remove unused fields from ArtistAdd (#4727) fix: Fix conflicting property name for Swagger (#4733) fix: fixed stats controller (#4742) fix(webhook): Remove added trailing slash from webhook URL #4710 fix(sonarr): 🐛 Cleaned up and removed Sonarr v3 option, sonarr v3 is now the default. This allows us to get ready for the upcoming Sonarr v4 (#4764) fix: Fixes default image for recently requested items. (#4767) Fixes build warnings. (#4769) fix: Reworked the version check (#4719) (#4781) fix: Unable to Delete Jellyfin Server (#4705) (#4780) fix: Partially Available prevents further TV requests (#4768) (#4779) fix(emby): Fix Emby played sync running a full sync during recently added sync (#4932) Fixes #4947 fix: Fix various styling issues (#4935) fix(translations): 🌐 New translations from Crowdin [skip ci] (#4926) fix: upgrade @microsoft/signalr from 6.0.11 to 6.0.16 (#4964) [skip ci] fix: upgrade primeng from 15.0.0-rc.1 to 15.4.1 (#4962) [skip ci] fix: src/Ombi.Notifications/Ombi.Notifications.csproj to reduce vulnerabilities (#4969) [skip ci] fix: upgrade @fortawesome/fontawesome-free from 6.1.2 to 6.4.0 (#4965) [skip ci] fix: upgrade multiple dependencies with Snyk (#4963) [skip ci] fix flaky tests (#4970) [skip ci] fix: More automation tests mainly around the Plex Settings page (#4821) fix: upgrade cypress-real-events from 1.7.4 to 1.8.1 (#4968) [skip ci] fix: Remove Angular TSLint (#4973) fix: upgrade zone.js from 0.11.8 to 0.13.0 (#4975) fix: upgrade jquery from 3.6.1 to 3.7.0 (#4974) fix: upgrade multiple dependencies with Snyk (#4961) fixes (#4978) fix(user-importer): 🐛 Fixed an issue where the cleanup wouldn't delete users #4812 fix(user-importer): Do not delete the Plex Admin as part of the user Importer cleanup #4870 (#4981) Fixes #4957 fix: Remove old trending source (#4987) fix(plex-api): Switch over to the new API to avoid deprecation & save… (#4986) fix: switch back to the old plex friends API #4989 fix(user-importer): Fixed not importing all correct users #4989 fix: upgrade cypress-real-events from 1.8.1 to 1.9.1 (#5000) [skip ci] fix: upgrade @microsoft/signalr from 6.0.18 to 6.0.20 (#4999) [skip ci] fix: upgrade @fortawesome/fontawesome-free from 6.4.0 to 6.4.2 (#5005) [skip ci] fix: upgrade @types/jquery from 3.5.16 to 3.5.17 (#5011) [skip ci] fix: src/Ombi/ClientApp/package.json & src/Ombi/ClientApp/yarn.lock to reduce vulnerabilities (#5010) [skip ci] fix: upgrade @microsoft/signalr from 6.0.21 to 6.0.22 (#5020) fix: upgrade @types/jquery from 3.5.18 to 3.5.19 (#5022) fix: upgrade zone.js from 0.13.1 to 0.13.2 (#5019) fix: upgrade multiple dependencies with Snyk (#5030) fix: upgrade cypress-real-events from 1.10.0 to 1.10.1 (#5014) fix: upgrade jquery from 3.7.0 to 3.7.1 (#5015) Fix: Linkify logo in newsletter (#5036) fix: upgrade @types/jquery from 3.5.22 to 3.5.23 (#5034) [skip ci] fix: upgrade @microsoft/signalr from 6.0.22 to 6.0.23 (#5032) [skip ci] Fix(mutliple servers): attempting to cache the Plex Content in server (#5018) fix(radarr-4k): 🐛 Fixed an issue when using Radarr 4k with user set quality profiles. There are now user quality profiles for 4k profile #5025 fix: src/Ombi/ClientApp/package.json & src/Ombi/ClientApp/yarn.lock to reduce vulnerabilities (#5072) [skip ci] fix: src/Ombi/Ombi.csproj to reduce vulnerabilities (#5066) [skip ci] fix: upgrade @fortawesome/fontawesome-free from 6.4.2 to 6.5.0 (#5053) [skip ci] fix: upgrade @types/jquery from 3.5.27 to 3.5.28 (#5049) [skip ci] fix: src/Ombi/ClientApp/package.json & src/Ombi/ClientApp/yarn.lock to reduce vulnerabilities (#5040) [skip ci] fix: upgrade moment from 2.29.4 to 2.30.1 (#5075) [skip ci] fix: upgrade multiple dependencies with Snyk (#5073) [skip ci] fix: upgrade multiple dependencies with Snyk (#5104) [skip ci]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
Users who have the "Request 4K Movie" role disabled can request 4K movies.
To Reproduce
Steps to reproduce the behavior:
Observed behavior:
A pop-up appears with choices for "Request" and "Request 4K"
Expected behavior:
Only the "Request" button should be available
Screenshots:
User does not have "Request 4K Movie" role enabled:
User can see and interact with "Request 4K" button:
Example of requested 4K movie:
Logs (Logs directory where Ombi is located)
There were no log entries on the date the request was made.
Desktop (please complete the following information):
Ombi Version (please complete the following information):
The text was updated successfully, but these errors were encountered: