Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for getting total layer number from last layer change comment #8

Closed
TomW1605 opened this issue Apr 11, 2018 · 12 comments
Closed
Labels
type: enhancement New feature or request
Milestone

Comments

@TomW1605
Copy link
Contributor

this would make it very easy for people to use your plugin with slic3r as well. slic3r allows for custom gcode to be added at each layer change and has a [layer_num] placeholder that lets you duplicate the ;LAYER:0 format from cura. however, slic3r has nothing that gives the total layers. it is possible with post processing but if you could use the last layer change comment then this would not be necessary.

@OllisGit OllisGit added the type: enhancement New feature or request label Apr 11, 2018
@OllisGit OllisGit added this to the V1.1.X milestone Apr 11, 2018
@OllisGit OllisGit added the status: waitingForFeedback Wating for Customers feedback label Apr 11, 2018
@OllisGit
Copy link
Owner

OllisGit commented Apr 11, 2018

just to make sure that I understand your enhancement:

  • instead of using the ;LAYER_COUNT: the plugin should use the last ;LAYER: comment
  • slic3r could provide the Cura-Layer format (;LAYER:), right!?!

I think this is a realy good enhancement and it should be easy to implement.
I will start implementing this ;-)

@TomW1605
Copy link
Contributor Author

yes it can. under printer settings there are custom gcode options
2018_04_12 08_27_12

@OllisGit OllisGit added status: inProgress and removed status: waitingForFeedback Wating for Customers feedback labels Apr 12, 2018
OllisGit pushed a commit that referenced this issue Apr 12, 2018
OllisGit pushed a commit that referenced this issue Apr 12, 2018
@OllisGit OllisGit modified the milestones: V1.1.X, V1.1.0 Apr 12, 2018
@OllisGit OllisGit added status: waitingForFeedback Wating for Customers feedback and removed status: inProgress labels Apr 12, 2018
@OllisGit
Copy link
Owner

The new Release 1.1.0 is out. Please test the new enhancement.
Thx, in advance
Olli

@TomW1605
Copy link
Contributor Author

it works for me

@OllisGit
Copy link
Owner

Great!

@reloxx13
Copy link

reloxx13 commented Jan 19, 2019

for the lazy copy&paste guys cuz in the comment above its an image

;LAYER:[layer_num]

would be nice to have it as default, just trying out slic3r and now the print is without layer count :S

@vitt82
Copy link

vitt82 commented May 7, 2020

for the lazy copy&paste guys cuz in the comment above its an image

;LAYER:[layer_num]

would be nice to have it as default, just trying out slic3r and now the print is without layer count :S

🥇

@Doprintityourself
Copy link

Hi It is not working for me here
Prusa Slicer 2.2 and 2.3Beta3
I have
;LAYER:[layer_num]
in bevore layer change gcode
grafik
but still getting no layer indicator as a warning
grafik
the gcode file contains the wanted line
grafik

but I only see
grafik
and in top status line layer of is missing
grafik

I have uploaded the file new but not working

Interestingly the file should be changed during the upload!?
but it seems totaly the same after download the upload and comparison of the two files
Should the uploaded file be modified?
thanks in advance

@Doprintityourself
Copy link

Very strange, reset all settings, rebooted and uploaded again, now it seems to work partially
Layer is progressing but total height is still not displayed
grafik

@Doprintityourself
Copy link

what the hack is going on after finishing it displays higher than total
grafik

I will now totally uninstall clean data and do a fresh install

@Doprintityourself
Copy link

Not consistant
I have installed it on my seccon server fresh, never had this plugin installed before
I have to say that it is a multiple instance install!
Outcome:
first printer
not working properly
grafik
seccond printer on xxx.xxx.xxx:5001
as it should be
grafik

any idea could the plugin fail becaus of mutliple instances?

@sandboxgangster
Copy link

;LAYER:[layer_num]

Simple Thing your must add a SPACE after ; (; LAYER:[layer_num])

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

6 participants