Better deal with uneval nodes #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We now have our own versions of left/right/next that all correctly jump over uneval nodes, in particular we want to avoid descending into uneval subtrees (as they may contain gibberish), or call sexp on an uneval node (as that will outright fail). See clj-commons/rewrite-clj#70
Olical
reviewed
Mar 29, 2019
| (recur (next-fn loc)) | ||
|
|
||
| (= :uneval (rzip/tag loc)) | ||
| (recur (skip-fn loc)) |
There was a problem hiding this comment.
Ah, makes sense, glad it's pretty well telegraphed as uneval. By uneval do you mean the #_ reader macro? Wasn't sure what the name meant exactly.
There was a problem hiding this comment.
exactly, uneval == #_ ...
Olical
approved these changes
Mar 29, 2019
|
Released under |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now have our own versions of left/right/next that all correctly jump over
uneval nodes, in particular we want to avoid descending into uneval subtrees (as
they may contain gibberish), or call sexp on an uneval node (as that will
outright fail).
See clj-commons/rewrite-clj#70
Closes #20