FIX: SORT/COMPARE is using reversed order when using integer as a res…

…ult from the function fixes: metaeducation/rebol-issues#2376
Oldes · May 24, 2019 · f65ffd9 · f65ffd9
1 parent 18e2d34
commit f65ffd9
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/src/core/t-block.c b/src/core/t-block.c
@@ -415,12 +415,12 @@ static struct {
 		return -1;
 	}
 	if (IS_INTEGER(val)) {
-		if (VAL_INT64(val) > 0) return 1;
+		if (VAL_INT64(val) < 0) return 1;
 		if (VAL_INT64(val) == 0) return 0;
 		return -1;
 	}
 	if (IS_DECIMAL(val)) {
-		if (VAL_DECIMAL(val) > 0) return 1;
+		if (VAL_DECIMAL(val) < 0) return 1;
 		if (VAL_DECIMAL(val) == 0) return 0;
 		return -1;
 	}

diff --git a/src/tests/units/series-test.r3 b/src/tests/units/series-test.r3
@@ -117,6 +117,8 @@ Rebol [
 --test-- "SORT/compare"
 	;@@ https://github.com/rebol/rebol-issues/issues/720
 	--assert [3 2 1] = sort/compare [1 2 3] func [a b] [a > b]
+	;@@ https://github.com/rebol/rebol-issues/issues/2376
+	--assert [1 3 10] = sort/compare [1 10 3] func[x y][case [x > y [1] x < y [-1] true [0]]]
 
 --test-- "SORT/skip/compare"
 	;@@ https://github.com/rebol/rebol-issues/issues/1152