FIX: checksum port crashes when input is not a series value

resolves: Oldes/Rebol-issues#2553
Oldes · Jun 16, 2023 · b624280 · b624280
1 parent 68e8afe
commit b624280
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 0 deletions.
diff --git a/src/core/p-checksum.c b/src/core/p-checksum.c
@@ -240,6 +240,7 @@
 		}
 		args = Find_Refines(ds, ALL_WRITE_REFS);
 		arg = D_ARG(2);
+		if (!ANY_BINSTR(arg)) Trap_Arg(arg);
 		REBI64  pos = (REBI64)VAL_INDEX(arg);
 		if (args & AM_WRITE_SEEK) {
 			pos += Int64(D_ARG(ARG_WRITE_INDEX));

diff --git a/src/tests/units/checksum-test.r3 b/src/tests/units/checksum-test.r3
@@ -208,6 +208,10 @@ if find system/catalog/checksums 'ripemd160 [
 		;opening already opened port restarts computation
 		--assert sum1 = read write/seek/part open port #{cafe0bad} 2 2
 		--assert sum1 = read write/seek/part open port tail #{cafe0bad} -2 2
+
+	--test-- "checksum port with invalid argument"
+	;@@ https://github.com/Oldes/Rebol-issues/issues/2553
+		--assert all [error? e: try [write checksum:md5 1]  e/id = 'invalid-arg]
 ===end-group===
 
 ===start-group=== "Checksum HMAC SHA"