Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fe 62 rolling dice #77

Merged
merged 53 commits into from
Oct 2, 2018
Merged

Fe 62 rolling dice #77

merged 53 commits into from
Oct 2, 2018

Conversation

RQMplays
Copy link
Collaborator

#62

… in MyBooks comp to tell them book edition's not available
…ls:[Roll], and create all C(R)UD method in resolvers
…stions only have their own personal graphql container and dumb comp is generic
@RQMplays RQMplays requested a review from Okazari September 28, 2018 14:27
@@ -41,10 +53,15 @@ class Game extends React.Component {
return el.getBoundingClientRect().bottom <= window.innerHeight + 50
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extraire dans un service

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if(window)

@@ -41,10 +53,15 @@ class Game extends React.Component {
return el.getBoundingClientRect().bottom <= window.innerHeight + 50
}

trackScrolling() {
trackScrolling(timeOut) {
const wrappedElement = document.getElementById('page')
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if(document)

GamePanels
.filter(panel => panelState === panel.key)
.map(panel => <panel.component key={panel.key} />)
GamePanels.reduce(
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Repasser au .filter .map

import { FontAwesomeIcon } from '@fortawesome/react-fontawesome'
import styles from './style.scss'

const AnimatedButton = posed.div({
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move into a specific container

})

return (
<AnimatedButton>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move into container


.forbidden {
display: none;
@media #{$lt-desktop} {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

todo

</div>
<div className={styles.forbidden}>
<Forbidden {...props} />
</div>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<GTMobileDisplay>
  <AppLayout {...props} tabs={tabs} />
</GTMobileDisplay>

</AnimatedItemRow>
))
}
</PoseGroup>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AnimatedList = ({ list, children }) => {
   <PoseGroup>
      {
         list.map((...args) => (
            <UpDownAnimatedRow>
              {children(...args)}
            </UpDownAnimatedRow>
         )
      }
   </PoseGroup>
}

<AnimatedList list={book.objects}>
  {
    (item) => <Bla toto={item.tg} />
  }
</AnimatedList>

import PageRow from './PageRow'
import styles from './styles.scss'

const AnimatedPageRow = posed.div(dataRow)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

idem

import StatRow from './StatRow'
import styles from './styles.scss'

const AnimatedStatRow = posed.div(dataRow)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

idem

@RQMplays RQMplays merged commit 87239ff into v2.0.0 Oct 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants