Game view #42
Merged
Game view #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d comp underneath
…ns from EffectService
…isplayStats comp in TrialToolbar
Okazari
added a commit
that referenced
this pull request
Jun 15, 2018
* 🎨 copy Link to commons * 🎨 move Toolbar to Toolbars folder and rename it AppToolbar * 🚧 designing the game view * 🎨 Create GameView comp. for the game Layout, and move all Game related comp underneath * 💄 nightmode for GameView with not 50 but 2 shades of grey * 💄 switch Grey Tone for GameView * 💄 fix width 100% and margin-bottom for last transitions in GameView * 🚧 WIP query for trialGame * 🚧 create game object for trials in a graphQL query && updating some front display * ♻️ Refactor deletePage in graphQL resolver from forEach to Map * 🎨♻️ Create metadata object for Effects and Conditions in EffectService * ♻️ Refactor the mapping from object to use the key as value for options from EffectService * 🎨💄 move Trial and Game containers to their respective Views. Create DisplayStats comp in TrialToolbar * 💄 change style of DisplayStats * ✨🎨 add DisplayObjects to TrialToolbar too * 🐛🚨 fixing no key in iterator for react in DisplayStats/Objects and GamePage comp. * ➕ add normalizr * 🚧 add schema and normalization for the book metaData * ♻️ modify deletePage resolver in RootSchema to change only toPage attr * ♻️ wrong double negations in GameTransition * 💄♻️ change margin on transitionButton * ♻️ refactor usage of EffectService in Effect and Condition Input * ♻️ change wrong variable name on previous refacto
Okazari
added a commit
that referenced
this pull request
Jun 15, 2018
* 🎨 copy Link to commons * 🎨 move Toolbar to Toolbars folder and rename it AppToolbar * 🚧 designing the game view * 🎨 Create GameView comp. for the game Layout, and move all Game related comp underneath * 💄 nightmode for GameView with not 50 but 2 shades of grey * 💄 switch Grey Tone for GameView * 💄 fix width 100% and margin-bottom for last transitions in GameView * 🚧 WIP query for trialGame * 🚧 create game object for trials in a graphQL query && updating some front display * ♻️ Refactor deletePage in graphQL resolver from forEach to Map * 🎨♻️ Create metadata object for Effects and Conditions in EffectService * ♻️ Refactor the mapping from object to use the key as value for options from EffectService * 🎨💄 move Trial and Game containers to their respective Views. Create DisplayStats comp in TrialToolbar * 💄 change style of DisplayStats * ✨🎨 add DisplayObjects to TrialToolbar too * 🐛🚨 fixing no key in iterator for react in DisplayStats/Objects and GamePage comp. * ➕ add normalizr * 🚧 add schema and normalization for the book metaData * ♻️ modify deletePage resolver in RootSchema to change only toPage attr * ♻️ wrong double negations in GameTransition * 💄♻️ change margin on transitionButton * ♻️ refactor usage of EffectService in Effect and Condition Input * ♻️ change wrong variable name on previous refacto
Okazari
added a commit
that referenced
this pull request
Jun 18, 2018
* 🎨 copy Link to commons * 🎨 move Toolbar to Toolbars folder and rename it AppToolbar * 🚧 designing the game view * 🎨 Create GameView comp. for the game Layout, and move all Game related comp underneath * 💄 nightmode for GameView with not 50 but 2 shades of grey * 💄 switch Grey Tone for GameView * 💄 fix width 100% and margin-bottom for last transitions in GameView * 🚧 WIP query for trialGame * 🚧 create game object for trials in a graphQL query && updating some front display * ♻️ Refactor deletePage in graphQL resolver from forEach to Map * 🎨♻️ Create metadata object for Effects and Conditions in EffectService * ♻️ Refactor the mapping from object to use the key as value for options from EffectService * 🎨💄 move Trial and Game containers to their respective Views. Create DisplayStats comp in TrialToolbar * 💄 change style of DisplayStats * ✨🎨 add DisplayObjects to TrialToolbar too * 🐛🚨 fixing no key in iterator for react in DisplayStats/Objects and GamePage comp. * ➕ add normalizr * 🚧 add schema and normalization for the book metaData * ♻️ modify deletePage resolver in RootSchema to change only toPage attr * ♻️ wrong double negations in GameTransition * 💄♻️ change margin on transitionButton * ♻️ refactor usage of EffectService in Effect and Condition Input * ♻️ change wrong variable name on previous refacto
Okazari
added a commit
that referenced
this pull request
Jun 18, 2018
* 🎨 copy Link to commons * 🎨 move Toolbar to Toolbars folder and rename it AppToolbar * 🚧 designing the game view * 🎨 Create GameView comp. for the game Layout, and move all Game related comp underneath * 💄 nightmode for GameView with not 50 but 2 shades of grey * 💄 switch Grey Tone for GameView * 💄 fix width 100% and margin-bottom for last transitions in GameView * 🚧 WIP query for trialGame * 🚧 create game object for trials in a graphQL query && updating some front display * ♻️ Refactor deletePage in graphQL resolver from forEach to Map * 🎨♻️ Create metadata object for Effects and Conditions in EffectService * ♻️ Refactor the mapping from object to use the key as value for options from EffectService * 🎨💄 move Trial and Game containers to their respective Views. Create DisplayStats comp in TrialToolbar * 💄 change style of DisplayStats * ✨🎨 add DisplayObjects to TrialToolbar too * 🐛🚨 fixing no key in iterator for react in DisplayStats/Objects and GamePage comp. * ➕ add normalizr * 🚧 add schema and normalization for the book metaData * ♻️ modify deletePage resolver in RootSchema to change only toPage attr * ♻️ wrong double negations in GameTransition * 💄♻️ change margin on transitionButton * ♻️ refactor usage of EffectService in Effect and Condition Input * ♻️ change wrong variable name on previous refacto
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.