Removing dependency on #ribbon #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There are something like ribbon bar control being able to create office alike ribbon bar, is that true? I got this from a UI component site. I am a bit confused how the 3rd party components producer achieve this? They did it by a group?. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi OkGoDoIt,
nice office ribbon!
In switchToTabByIndex function you have a line like "$('#ribbon .ribbon-tab').hide();" so basically if I decide to give my ribbon a different ID, this code will break.
Also you get an id ($.fn.ribbon = function(id) {) as parameter. This should not be necessary if call it with $ ("#someid").ribbon.
This pull request solves both issues.