New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SplitToken: Move to private constructor model #94

Merged

Menelion merged 2 commits into master from private-ctor

Apr 19, 2024

Contributor

Menelion commented Apr 19, 2024

Go for private constructor with create() and fromString() static methods
Make all the fields nullable, except for database connection
Remove PHP CodeSniffer for the time being
Eternal tokens have expiration time set to null
The value 0 of the expiration time field means default expiration time, i.e., plus one hour
Remove setters as they are not needed anymore

Menelion added 2 commits

April 20, 2024 01:18


          Move to private constructor model

e70251e


          Remove PHPCS from CI

8ce178e

Menelion merged commit c110877 into master

26 checks passed

Menelion deleted the private-ctor branch

April 19, 2024 23:24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet