Skip to content

Commit

Permalink
Revert "Update exchange json tests with correct hb_pb_cat_dur (prebid…
Browse files Browse the repository at this point in the history
…#3836)"

This reverts commit 121b4ec.
  • Loading branch information
krdzo authored Oct 30, 2024
1 parent 3328567 commit b74653b
Show file tree
Hide file tree
Showing 8 changed files with 18 additions and 54 deletions.
8 changes: 3 additions & 5 deletions exchange/exchange_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -5568,10 +5568,9 @@ type bidderSeatBid struct {
// bidderBid is basically a subset of entities.PbsOrtbBid from exchange/bidder.go.
// See the comment on bidderSeatBid for more info.
type bidderBid struct {
Bid *openrtb2.Bid `json:"ortbBid,omitempty"`
Type string `json:"bidType,omitempty"`
BidVideo *openrtb_ext.ExtBidPrebidVideo `json:"bidVideo,omitempty"`
Meta *openrtb_ext.ExtBidPrebidMeta `json:"bidMeta,omitempty"`
Bid *openrtb2.Bid `json:"ortbBid,omitempty"`
Type string `json:"bidType,omitempty"`
Meta *openrtb_ext.ExtBidPrebidMeta `json:"bidMeta,omitempty"`
}

type mockIdFetcher map[string]string
Expand Down Expand Up @@ -5618,7 +5617,6 @@ func (b *validatingBidder) requestBid(ctx context.Context, bidderRequest BidderR
bids[i] = &entities.PbsOrtbBid{
OriginalBidCPM: mockSeatBid.Bids[i].Bid.Price,
Bid: mockSeatBid.Bids[i].Bid,
BidVideo: mockSeatBid.Bids[i].BidVideo,
BidType: openrtb_ext.BidType(mockSeatBid.Bids[i].Type),
BidMeta: mockSeatBid.Bids[i].Meta,
}
Expand Down
8 changes: 2 additions & 6 deletions exchange/exchangetest/append-bidder-names.json
Original file line number Diff line number Diff line change
Expand Up @@ -148,14 +148,10 @@
"hb_cache_path_appnex": "/pbcache/endpoint",
"hb_pb": "0.20",
"hb_pb_appnexus": "0.20",
"hb_pb_cat_dur": "0.20_VideoGames_30s_appnexus",
"hb_pb_cat_dur_appnex": "0.20_VideoGames_30s_appnexus",
"hb_pb_cat_dur": "0.20_VideoGames_0s_appnexus",
"hb_pb_cat_dur_appnex": "0.20_VideoGames_0s_appnexus",
"hb_size": "200x250",
"hb_size_appnexus": "200x250"
},
"video": {
"duration": 30,
"primary_category": ""
}
}
}
Expand Down
8 changes: 2 additions & 6 deletions exchange/exchangetest/debuglog_disabled.json
Original file line number Diff line number Diff line change
Expand Up @@ -157,14 +157,10 @@
"hb_cache_path_appnex": "/pbcache/endpoint",
"hb_pb": "0.20",
"hb_pb_appnexus": "0.20",
"hb_pb_cat_dur": "0.20_VideoGames_30s",
"hb_pb_cat_dur_appnex": "0.20_VideoGames_30s",
"hb_pb_cat_dur": "0.20_VideoGames_0s",
"hb_pb_cat_dur_appnex": "0.20_VideoGames_0s",
"hb_size": "200x250",
"hb_size_appnexus": "200x250"
},
"video": {
"duration": 30,
"primary_category": ""
}
}
}
Expand Down
8 changes: 2 additions & 6 deletions exchange/exchangetest/debuglog_enabled.json
Original file line number Diff line number Diff line change
Expand Up @@ -159,14 +159,10 @@
"hb_cache_path_appnex": "/pbcache/endpoint",
"hb_pb": "0.20",
"hb_pb_appnexus": "0.20",
"hb_pb_cat_dur": "0.20_VideoGames_30s",
"hb_pb_cat_dur_appnex": "0.20_VideoGames_30s",
"hb_pb_cat_dur": "0.20_VideoGames_0s",
"hb_pb_cat_dur_appnex": "0.20_VideoGames_0s",
"hb_size": "200x250",
"hb_size_appnexus": "200x250"
},
"video": {
"duration": 30,
"primary_category": ""
}
}
}
Expand Down
8 changes: 2 additions & 6 deletions exchange/exchangetest/generate-bid-id-error.json
Original file line number Diff line number Diff line change
Expand Up @@ -121,14 +121,10 @@
"hb_cache_path_appnex": "/pbcache/endpoint",
"hb_pb": "0.20",
"hb_pb_appnexus": "0.20",
"hb_pb_cat_dur": "0.20_VideoGames_30s_appnexus",
"hb_pb_cat_dur_appnex": "0.20_VideoGames_30s_appnexus",
"hb_pb_cat_dur": "0.20_VideoGames_0s_appnexus",
"hb_pb_cat_dur_appnex": "0.20_VideoGames_0s_appnexus",
"hb_size": "200x250",
"hb_size_appnexus": "200x250"
},
"video": {
"duration": 30,
"primary_category": ""
}
}
}
Expand Down
15 changes: 3 additions & 12 deletions exchange/exchangetest/generate-bid-id-many.json
Original file line number Diff line number Diff line change
Expand Up @@ -67,8 +67,7 @@
},
"bidType": "video",
"bidVideo": {
"duration": 30,
"PrimaryCategory": ""
"duration": 30
}
}
],
Expand Down Expand Up @@ -101,11 +100,7 @@
"meta": {
},
"bidid": "bid-appnexus-1",
"type": "video",
"video": {
"duration": 30,
"primary_category": ""
}
"type": "video"
}
}
},
Expand All @@ -125,11 +120,7 @@
"meta": {
},
"bidid": "bid-appnexus-2",
"type": "video",
"video": {
"duration": 30,
"primary_category": ""
}
"type": "video"
}
}
}
Expand Down
9 changes: 2 additions & 7 deletions exchange/exchangetest/generate-bid-id-one.json
Original file line number Diff line number Diff line change
Expand Up @@ -50,8 +50,7 @@
},
"bidType": "video",
"bidVideo": {
"duration": 30,
"primary_category": ""
"duration": 30
}
}
],
Expand Down Expand Up @@ -84,11 +83,7 @@
"meta": {
},
"bidid": "bid-appnexus-1",
"type": "video",
"video": {
"duration": 30,
"primary_category": ""
}
"type": "video"
}
}
}
Expand Down
8 changes: 2 additions & 6 deletions exchange/exchangetest/include-brand-category.json
Original file line number Diff line number Diff line change
Expand Up @@ -146,14 +146,10 @@
"hb_cache_path_appnex": "/pbcache/endpoint",
"hb_pb": "0.20",
"hb_pb_appnexus": "0.20",
"hb_pb_cat_dur": "0.20_VideoGames_30s",
"hb_pb_cat_dur_appnex": "0.20_VideoGames_30s",
"hb_pb_cat_dur": "0.20_VideoGames_0s",
"hb_pb_cat_dur_appnex": "0.20_VideoGames_0s",
"hb_size": "200x250",
"hb_size_appnexus": "200x250"
},
"video": {
"duration": 30,
"primary_category": ""
}
}
}
Expand Down

0 comments on commit b74653b

Please sign in to comment.