Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: need to upgrade version of team-ai sdk #12690

Merged
merged 4 commits into from
Nov 8, 2024
Merged

fix: need to upgrade version of team-ai sdk #12690

merged 4 commits into from
Nov 8, 2024

Conversation

frankqianms
Copy link
Contributor

@frankqianms frankqianms commented Nov 8, 2024

Copy link

github-actions bot commented Nov 8, 2024

Fx-core feat commits:

CLI feat commits:

Extension-toolkit feat commits:

SDK feat commits:

SDK React feat commits:

.Net SDK feat commits:

Fx-core fix commits:

CLI fix commits:

Extension-toolkit fix commits:

SDK fix commits:

SDK React fix commits:

.Net SDK fix commits:

Copy link

codecov bot commented Nov 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.03%. Comparing base (4c4bccf) to head (8d95b8b).
Report is 5 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main   #12690   +/-   ##
=======================================
  Coverage   90.03%   90.03%           
=======================================
  Files         576      576           
  Lines       34184    34184           
  Branches     6818     6777   -41     
=======================================
  Hits        30779    30779           
  Misses       1499     1499           
  Partials     1906     1906           

blackchoey
blackchoey previously approved these changes Nov 8, 2024
Copy link

github-actions bot commented Nov 8, 2024

Fx-core feat commits:

CLI feat commits:

Extension-toolkit feat commits:

SDK feat commits:

SDK React feat commits:

.Net SDK feat commits:

Fx-core fix commits:

CLI fix commits:

Extension-toolkit fix commits:

SDK fix commits:

SDK React fix commits:

.Net SDK fix commits:

Copy link

github-actions bot commented Nov 8, 2024

Fx-core feat commits:

CLI feat commits:

Extension-toolkit feat commits:

SDK feat commits:

SDK React feat commits:

.Net SDK feat commits:

Fx-core fix commits:

CLI fix commits:

Extension-toolkit fix commits:

SDK fix commits:

SDK React fix commits:

.Net SDK fix commits:

Copy link

github-actions bot commented Nov 8, 2024

Fx-core feat commits:

CLI feat commits:

Extension-toolkit feat commits:

SDK feat commits:

SDK React feat commits:

.Net SDK feat commits:

Fx-core fix commits:

CLI fix commits:

Extension-toolkit fix commits:

SDK fix commits:

SDK React fix commits:

.Net SDK fix commits:

@@ -55,6 +55,9 @@ This app template also demonstrates usage of techniques like:
Upload new documents succeeded. If they do not exist, wait for several seconds...
setup finished
```
1. After creating index, please go to your index portal page to set the `descriptionVector` field as retrievable
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In our setup.py, descriptionVector field is not default set to "retrievable" anymore. Maybe it is because the latest upgrade of azure.search.document to 11.5.2 on Oct.31. But only downgrading the package doesn't work.

The current workaround is to tell users in Readme to manually set the field as retrievable.

@MSFT-yiz MSFT-yiz merged commit 21ec75c into main Nov 8, 2024
18 checks passed
@MSFT-yiz MSFT-yiz deleted the frank/sdkupgrade branch November 8, 2024 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants