Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add schema validation for default language file #12576

Merged
merged 2 commits into from
Oct 24, 2024

Conversation

anchenyi
Copy link
Contributor

@anchenyi anchenyi commented Oct 23, 2024

Copy link

codecov bot commented Oct 23, 2024

Codecov Report

Attention: Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 89.94%. Comparing base (0b83296) to head (ef0a13e).
Report is 4 commits behind head on dev.

Files with missing lines Patch % Lines
.../fx-core/src/component/driver/teamsApp/validate.ts 88.88% 0 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              dev   #12576      +/-   ##
==========================================
- Coverage   89.94%   89.94%   -0.01%     
==========================================
  Files         571      571              
  Lines       33794    33801       +7     
  Branches     6552     6706     +154     
==========================================
+ Hits        30397    30403       +6     
  Misses       1495     1495              
- Partials     1902     1903       +1     
Files with missing lines Coverage Δ
...e/src/component/driver/teamsApp/utils/telemetry.ts 100.00% <100.00%> (ø)
.../fx-core/src/component/driver/teamsApp/validate.ts 91.16% <88.88%> (-0.27%) ⬇️

@anchenyi anchenyi marked this pull request as ready for review October 24, 2024 03:21
@anchenyi anchenyi merged commit 06b47a8 into dev Oct 24, 2024
28 checks passed
@anchenyi anchenyi deleted the anchenyi/default_lang_file_validate branch October 24, 2024 05:34
huimiu pushed a commit that referenced this pull request Nov 8, 2024
* feat: add validations for default localization files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants