Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add schema validation for localization files #12537

Merged
merged 7 commits into from
Oct 23, 2024

fix: ut

a73deb5
Select commit
Loading
Failed to load commit list.
Merged

feat: add schema validation for localization files #12537

fix: ut
a73deb5
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 22, 2024 in 1s

89.93% (+0.26%) compared to ef1e054

View this Pull Request on Codecov

89.93% (+0.26%) compared to ef1e054

Details

Codecov Report

Attention: Patch coverage is 97.82609% with 1 line in your changes missing coverage. Please review.

Project coverage is 89.93%. Comparing base (ef1e054) to head (a73deb5).
Report is 102 commits behind head on dev.

Files with missing lines Patch % Lines
.../fx-core/src/component/driver/teamsApp/validate.ts 97.82% 0 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              dev   #12537      +/-   ##
==========================================
+ Coverage   89.66%   89.93%   +0.26%     
==========================================
  Files         583      571      -12     
  Lines       34668    33761     -907     
  Branches     6768     6696      -72     
==========================================
- Hits        31085    30362     -723     
+ Misses       1588     1495      -93     
+ Partials     1995     1904      -91     
Files with missing lines Coverage Δ
.../fx-core/src/component/driver/teamsApp/validate.ts 91.42% <97.82%> (+5.16%) ⬆️

... and 52 files with indirect coverage changes