-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: modify manifests for PY templates, add CEAEnabled consume logic and add test case #12512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ogic and add test case
frankqianms
requested review from
adashen,
blackchoey,
yukun-dong,
hund030,
JerryYangKai and
eriolchan
as code owners
October 12, 2024 06:31
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #12512 +/- ##
==========================================
+ Coverage 89.66% 89.95% +0.28%
==========================================
Files 583 572 -11
Lines 34650 33864 -786
Branches 6841 6615 -226
==========================================
- Hits 31069 30461 -608
+ Misses 1588 1496 -92
+ Partials 1993 1907 -86
|
yukun-dong
previously approved these changes
Oct 12, 2024
blackchoey
reviewed
Oct 25, 2024
templates/python/custom-copilot-basic/appPackage/manifest.json.tpl
Outdated
Show resolved
Hide resolved
blackchoey
reviewed
Oct 25, 2024
templates/python/custom-copilot-rag-azure-ai-search/appPackage/manifest.json.tpl
Outdated
Show resolved
Hide resolved
blackchoey
reviewed
Oct 25, 2024
templates/python/custom-copilot-rag-custom-api/appPackage/manifest.json.tpl
Outdated
Show resolved
Hide resolved
blackchoey
reviewed
Oct 25, 2024
templates/python/custom-copilot-rag-custom-api/appPackage/manifest.json.tpl
Outdated
Show resolved
Hide resolved
blackchoey
approved these changes
Oct 25, 2024
yukun-dong
approved these changes
Oct 25, 2024
huimiu
pushed a commit
that referenced
this pull request
Nov 8, 2024
…ogic and add test case (#12512) * refactor: modify manifests for PY templates, add CEAEnabled consume logic and add test case * fix: bad manifest * refactor: modify schema url and version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
workitem: https://msazure.visualstudio.com/Microsoft%20Teams%20Extensibility/_workitems/edit/29830998