Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove spec auth support for VS plugin #12490

Merged
merged 2 commits into from
Oct 9, 2024
Merged

fix: remove spec auth support for VS plugin #12490

merged 2 commits into from
Oct 9, 2024

Conversation

KennethBWSong
Copy link
Contributor

@codecov Codecov
Copy link

codecov bot commented Oct 8, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.67%. Comparing base (be7db5f) to head (bc609a0).
Report is 2 commits behind head on dev.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##              dev   #12490   +/-   ##
=======================================
  Coverage   89.67%   89.67%           
=======================================
  Files         583      583           
  Lines       34621    34623    +2     
  Branches     6745     6658   -87     
=======================================
+ Hits        31045    31047    +2     
  Misses       1583     1583           
  Partials     1993     1993
Files with missing lines Coverage Δ
.../fx-core/src/component/generator/apiSpec/helper.ts 93.34% <100.00%> (+0.02%) ⬆️

@KennethBWSong KennethBWSong marked this pull request as ready for review October 9, 2024 01:50
@KennethBWSong KennethBWSong merged commit e9244f2 into dev Oct 9, 2024
18 checks passed
@KennethBWSong KennethBWSong deleted the bowsong/vs_plugin branch October 9, 2024 01:50
@github-actions github-actions bot mentioned this pull request Oct 22, 2024
Merged
huimiu pushed a commit that referenced this pull request Nov 8, 2024
@KennethBWSong @huimiu
fix: remove spec auth support for VS plugin (#12490)
0395d61 
* fix: remove spec auth support for VS plugin

* test: update ut
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuqizhou77 yuqizhou77 yuqizhou77 approved these changes

@SLdragon SLdragon SLdragon approved these changes

@nliu-ms nliu-ms Awaiting requested review from nliu-ms nliu-ms is a code owner

@Alive-Fish Alive-Fish Awaiting requested review from Alive-Fish Alive-Fish is a code owner

@jayzhang jayzhang Awaiting requested review from jayzhang jayzhang is a code owner

@anchenyi anchenyi Awaiting requested review from anchenyi anchenyi is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KennethBWSong @SLdragon @yuqizhou77