Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: add plugin improvement #12324

Merged
merged 4 commits into from
Sep 3, 2024
Merged

refactor: add plugin improvement #12324

merged 4 commits into from
Sep 3, 2024

Conversation

yuqizhou77
Copy link
Contributor

@yuqizhou77 yuqizhou77 commented Sep 3, 2024

  • several improvement and telemetry fix for add plugin

Copy link

codecov bot commented Sep 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.61%. Comparing base (fe75f00) to head (cabb7c0).
Report is 6 commits behind head on dev.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##              dev   #12324   +/-   ##
=======================================
  Coverage   89.60%   89.61%           
=======================================
  Files         582      582           
  Lines       34406    34418   +12     
  Branches     6748     6819   +71     
=======================================
+ Hits        30831    30844   +13     
  Misses       1586     1586           
+ Partials     1989     1988    -1     
Files with missing lines Coverage Δ
packages/cli/src/userInteraction.ts 82.50% <ø> (-0.07%) ⬇️
...es/fx-core/src/component/utils/envFunctionUtils.ts 92.63% <100.00%> (ø)
packages/fx-core/src/core/FxCore.ts 89.82% <100.00%> (ø)
...extension/src/telemetry/vscodeTelemetryReporter.ts 60.25% <100.00%> (+0.51%) ⬆️

... and 6 files with indirect coverage changes

@yuqizhou77 yuqizhou77 changed the title refactor: add help link refactor: add plugin improvement Sep 3, 2024
@yuqizhou77 yuqizhou77 marked this pull request as ready for review September 3, 2024 06:50
@yuqizhou77 yuqizhou77 merged commit acb8134 into dev Sep 3, 2024
28 checks passed
@yuqizhou77 yuqizhou77 deleted the yuqzho/add-plugin-minor branch September 3, 2024 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants