Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ npm run change
Description of changes
Tightens typings in GroupHeader, which is used in GroupedList. Right now, I'm pretty sure the prop
isGroupLoading
will never work.headerProps
doesn't exist onIGroupHeaderProps
, so theisGroupLoading
const would have always been undefined.The original
IGroupHeaderProps
hadheaderProps
, but when that API was changed, this part of the code probably went unnoticed since it didn't have proper typing.Focus areas to test
Ensure that
IGroupHeaderProps
'sisGroupLoading
(extended fromIGroupDividerProps
) works correctly now.I'll see if I can write a test for this change, too.
Microsoft Reviewers: Open in CodeFlow