-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated socks package to a version that doesn't use the IP package #2177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jadahiya-MSFT
previously approved these changes
Feb 15, 2024
AE-MS
reviewed
Feb 15, 2024
AE-MS
reviewed
Feb 15, 2024
AE-MS
requested changes
Feb 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few questions
jadahiya-MSFT
previously approved these changes
Feb 15, 2024
AE-MS
approved these changes
Feb 15, 2024
jadahiya-MSFT
approved these changes
Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For more information about how to contribute to this repo, visit this page.
Description
This repo has a CG violation for the
ip
project. Theip
project has a published security vulnerability:indutny/node-ip#136
GHSA-78xj-cgh5-2h22
Unfortunately, there's no fixed version of the
ip
project. Moreover, there are questions in the "Issues" section of that project asking whether there's even a maintainer for it.We indirectly use
ip
because we use lerna, which has a whole chain of dependencies which eventually leads toip
The package in that chain which depends on
ip
issocks.
The socks package HAS been updated to stop depending on "ip" given the uncertainty of getting a fix inip.
This change forces us to use the latest version of socks that removes the
ip
dependency. Eventually, over probably a while, the wholelerna
dependency change will update to use this newer version of socks, but who knows how long that will take. In the meantime, this override ensures that with our current set of dependencies we no longer consume the vulnerable version ofip.
I also added a section to our package.json file that provides room to explain what each override is for, as a way of hopefully helping our future selves to know when we might be able to remove any of them. As the explanation the file says, it's a hacky way of putting comments in the file since comments are not allowed in JSON.
Main changes in the PR:
Override
socks
package inpackage.json
file.Unit Tests added:
N/A
End-to-end tests added:
N/A
Additional Requirements
Change file added:
N/A