Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bot Framework v4 Conversion #50

Open
wants to merge 28 commits into
base: main
Choose a base branch
from
Open

Bot Framework v4 Conversion #50

wants to merge 28 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Aug 23, 2019

In this PR, the following changes are addressed:

  1. The overall Bot Framework version has been updated from Bot Framework v3 to Bot Framework v4
  2. Many of the cards are also directly converted from the JSON payload to the AdaptiveCards SDK
  3. Added the typing indicator
  4. Made sure to utilize Autofac DI framework

Pranav Krishnamurthy added 19 commits August 21, 2019 17:07
Commencing the necessary steps for converting the Icebreaker from v3 …
93c976e 
…to BF v4
More changes being made
1ad481a
Having more changes made for bot framework v4
1e95bf5
Getting things to one stage
3e72bc7
Having the v4 conversion under way
e5378b6
Adding the changes for the welcome message in the team scope right now
4b692d8
Welcome card is created for the team
08759f1
Adding the necessary changes for the welcome card in personal scope
d9b2735
Getting the user welcome message almost done
2817f51
Having the necessary changes made for optin and optout
01b78c2
Having the unrecognized input card correctly included
ed2e7e1
Properly handling the unrecognized input
02c1dfd
Having to start on the pair ups
70274d8
Having the finishing touches left to do
8d53cc1
Having the ability to get the necessary things close to completion
bb6aca9
Having things nearly done
ef7fa9d
Having more changes for all the properties
17694b7
Having the necessary things done properly
d6bde95
Having the adaptive cards converted from JSON payload to Adaptive car…
1d2aed2 
…ds SDK
@ghost ghost requested review from aosolis and jotrick August 23, 2019 19:31
aosolis
aosolis requested changes Aug 29, 2019
View reviewed changes
Source/Icebreaker/AdapterWithErrorHandler.cs Outdated Show resolved Hide resolved
Source/Icebreaker/AdapterWithErrorHandler.cs Outdated Show resolved Hide resolved
Source/Icebreaker/Cards/PairUpNotificationCard.cs Outdated Show resolved Hide resolved
Source/Icebreaker/Cards/UnrecognizedInputCard.cs Outdated Show resolved Hide resolved
Source/Icebreaker/Cards/UserWelcomeCard.cs Outdated Show resolved Hide resolved
Source/Icebreaker/App_Start/AutofacConfig.cs Outdated Show resolved Hide resolved
Source/Icebreaker/App_Start/AutofacConfig.cs Outdated Show resolved Hide resolved
Source/Icebreaker/Web.config Outdated Show resolved Hide resolved
Source/Icebreaker/packages.config Outdated Show resolved Hide resolved
Source/Icebreaker/packages.config Outdated Show resolved Hide resolved
ghost
ghost commented Aug 29, 2019
View reviewed changes
Copy link
Author

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your requested changes have been implemented @aosolis

Source/Icebreaker/AdapterWithErrorHandler.cs Outdated Show resolved Hide resolved
Source/Icebreaker/AdapterWithErrorHandler.cs Outdated Show resolved Hide resolved
Source/Icebreaker/App_Start/AutofacConfig.cs Outdated Show resolved Hide resolved
Source/Icebreaker/App_Start/AutofacConfig.cs Outdated Show resolved Hide resolved
Source/Icebreaker/App_Start/AutofacConfig.cs Outdated Show resolved Hide resolved
Source/Icebreaker/Cards/UnrecognizedInputCard.cs Outdated Show resolved Hide resolved
Source/Icebreaker/Cards/UserWelcomeCard.cs Outdated Show resolved Hide resolved
Source/Icebreaker/Web.config Outdated Show resolved Hide resolved
Source/Icebreaker/Cards/PairUpNotificationCard.cs Outdated Show resolved Hide resolved
Source/Icebreaker/Cards/UserWelcomeCard.cs Outdated Show resolved Hide resolved
Having all of the necessary parameters correct - ensuring that the ca…
9724f1d 
…sting is also done to get the right information
@microsoft-github-updates microsoft-github-updates bot changed the base branch from master to main January 6, 2021 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jotrick jotrick Awaiting requested review from jotrick

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@aosolis