Skip to content
This repository has been archived by the owner on Jul 22, 2024. It is now read-only.

Bug fixes #40

Merged
merged 2 commits into from
Apr 27, 2015
Merged

Bug fixes #40

merged 2 commits into from
Apr 27, 2015

Conversation

dclaux
Copy link
Contributor

@dclaux dclaux commented Apr 24, 2015

  • Fixes KeyNotFound exception in DictionaryProperty when a value is removed from dictionary
  • Introduces new Folder.WellKnwonFolderNameAsString property to expose a folder's well known name even if that name isn't defined in the WellKnownFolderName enumeration
  • Fixes a bug in StreamingSubscriptionConnection that made it impossible to re-open the connection in its OnDisconnect handler

…emoved from dictionary

- Introduces new Folder.WellKnwonFolderNameAsString property to expose a folder's well known name even if that name isn't defined in the WellKnownFolderName enumeration
- Fixes a bug in StreamingSubscriptionConnection that made it impossible to re-open the connection in its OnDisconnect handler
@azurecla
Copy link

Hi @dclaux, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
We will now validate the agreement and then real humans will evaluate your PR.

TTYL, AZPRBOT;

@WGroenestein
Copy link
Contributor

WellKnownFolderName solution looks good. Not sure on the other 2 fixes mentioned in the comment as i don't see any code for it?

@dclaux
Copy link
Contributor Author

dclaux commented Apr 24, 2015

Good catch, thanks :) I'm working on two versions of the code and forgot to make a change in one file for this commit.

  • Folder.cs, FolderSchema.cs and EwsUtilities.cs contain the changes that introduce WellKnownFolderNameAsString
  • StreamingSubscriptionConnection.cs contains the change that allows re-opening in OnDisconnect
  • DictionaryProperty.cs contains a change that fixes the KeyNotFound issue

dclaux added a commit that referenced this pull request Apr 27, 2015
@dclaux dclaux merged commit 31951f4 into OfficeDev:master Apr 27, 2015
@dclaux dclaux deleted the Fixes branch May 19, 2015 17:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants