Fix processing of transactions in expressLaneService #2850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cla-bot
bot
added
the
s
Tristan-Wilson
requested changes
Dec 30, 2024
Tristan-Wilson
approved these changes
Dec 30, 2024
ganeshvanahalli
merged commit 2ac7fea
into
express-lane-timeboost
9 of 10 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes how the expressLaneService handles transactions to be in sync with the behavior of sequencer. The controller would now get appropriate errors for the transactions they submit no matter in which order they submit them- if the transactions cant be processed, i.e their sequence numbers are not in sync with the round's global sequence count the txs will error after a timeout (2 *
--execution.sequencer.queue-timeout).Transaction that clears the initial validation process will get eventually submitted to the sequencer, in which case it ends up consuming the sequence number (i.e this sequence number can't be used for another transaction) irrespective of the transaction's result. These kind of accepted transactions would be given a detailed error starting with
Accepted timeboost tx failed...string containing tx's sequence number, hash and the error (one of them being a timeout error). If a tx returns with a non-nil error that doesn't start with the above string then it implies that sequence number wasn't consumed and controller can use it to send another transaction.Resolves NIT-3008