pre-bold instead of develop as the exception branch used to check submodule pin for nitro-contracts #2846
+3
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…module pin for nitro-contracts
cla-bot
bot
added
the
s
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in OffchainLabs/nitro-contracts#284, current version of develop branch of nitro-contracts is not compatible with nitro, so a pre-bold branch, checked out from main, was created to support changes that should be introduced to nitro while bold is not fully integrated to it.
This PR uses pre-bold instead of develop as the exception branch used to check submodule pin for nitro-contracts.
This unblocks #2837, that pins pre-bold branch of nitro-contracts and needs "Submodule Pin Check" to be reported.
The workflow related to "Submodule Pin Check" only runs scripts that are in nitro's master branch.
The changes of this PR should be reverted once nitro starts supporting the develop branch of nitro-contracts again.