Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NIT-2799] Add mock external signer binary #2842

Merged
merged 3 commits into from
Jan 16, 2025
Merged

[NIT-2799] Add mock external signer binary #2842

merged 3 commits into from
Jan 16, 2025
+128 −39

Conversation

amsanghi
Copy link
Contributor

@amsanghi amsanghi commented Dec 19, 2024 •
edited
Loading

Fixes: NIT-2799

@cla-bot cla-bot bot added the s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA. label Dec 19, 2024
@amsanghi amsanghi changed the title Add mock external signer binary [NIT-2799] Add mock external signer binary Dec 19, 2024
@codecov Codecov
Copy link

codecov bot commented Dec 19, 2024

Codecov Report

Attention: Patch coverage is 71.42857% with 4 lines in your changes missing coverage. Please review.

Project coverage is 22.67%. Comparing base (36ac667) to head (5fb7c01).

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #2842      +/-   ##
==========================================
+ Coverage   22.56%   22.67%   +0.10%     
==========================================
  Files         269      269              
  Lines       39696    39709      +13     
==========================================
+ Hits         8957     9003      +46     
+ Misses      29260    29237      -23     
+ Partials     1479     1469      -10

@amsanghi amsanghi marked this pull request as ready for review December 19, 2024 15:07
eljobe
eljobe approved these changes Jan 6, 2025
View reviewed changes
Copy link
Member

@eljobe eljobe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

PlasmaPower
PlasmaPower approved these changes Jan 15, 2025
View reviewed changes
Copy link
Collaborator

@PlasmaPower PlasmaPower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assuming it works in the test node

@eljobe eljobe enabled auto-merge January 16, 2025 12:00
@eljobe eljobe merged commit 46d9938 into master Jan 16, 2025
16 checks passed
@eljobe eljobe deleted the mock_external_signer branch January 16, 2025 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PlasmaPower PlasmaPower PlasmaPower approved these changes

@eljobe eljobe eljobe approved these changes

Assignees
No one assigned
Labels
design-approved s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amsanghi @eljobe @PlasmaPower