Refactor RoundTimingInfo, fix auctionCloseTicker #2841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The logic for the calculations of "when does the next round start?", "what round is it?", "is the auction closed?", was spread throughout the code and required passing around multiple separate variables that all come from the RoundTimingInfo from the ExpressLaneAuction contract and should never change. This commit adds a domain specific RoundTimingInfo that validates these fields on construction and consolidates the aforementioned calculations. This commit also contanis a fix for auctionCloseTicker, now roundTicker. It used to assume the initial Offset timestamp fetched from the ExpressLaneAuction contract would always start on a minute boundary, and the round length would be a minute which is not always the case. This commit changes it to be called roundTicker and it now uses standard methods on the new RoundTimingInfo which take into account all possibilities for initial offset and round duration.
cla-bot
bot
added
the
s
6 tasks
|
Merging into #2561 now so Ganesh and I can keep working against that branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logic for the calculations of "when does the next round start?", "what round is it?", "is the auction closed?", was spread throughout the code and required passing around multiple separate variables that all come from the RoundTimingInfo from the ExpressLaneAuction contract and should never change. This commit adds a domain specific RoundTimingInfo that validates these fields on construction and consolidates the aforementioned calculations.
This commit also contanis a fix for auctionCloseTicker, now roundTicker. It used to assume the initial Offset timestamp fetched from the ExpressLaneAuction contract would always start on a minute boundary, and the round length would be a minute which is not always the case. This commit changes it to be called roundTicker and it now uses standard methods on the new RoundTimingInfo which take into account all possibilities for initial offset and round duration.
Testing done
Unit tests pass.
Re-ran https://github.com/OffchainLabs/timeboost-test against local nitro testnode with offset set to 30s within the minute, it passes up until the end when it has run out of time in the round due to the test also assuming minute boundaries.