Update BoLD Submodule and Add Newly Supported Flags to BoLD Staker #2835
Conversation
cla-bot
bot
added
the
s
|
I think the nitro-testnode submodule was accidentally reverted in this PR |
| stackOpts = append(stackOpts, challengemanager.StackWithoutAutoDeposit()) | ||
| } | ||
| if !config.AutoIncreaseAllowance { | ||
| stackOpts = append(stackOpts, challengemanager.StackWithoutAutoAllowanceApproval()) |
There was a problem hiding this comment.
Why isn't this code also for the assertion chain? Does the assertion chain not do auto allowance? Same thing for the delegated staking, maybe I'm just not sure what's the responsibility of the challenge manager vs assertion chain.
There was a problem hiding this comment.
The challenge manager spins up something called an assertion manager, and it is the assertion manager that does the auto allowance approval, auto deposit, and delegated staking on startup. The assertion chain is an abstraction over the Go bindings to Solidity which also do auto-deposit each time it makes a move related to the stake token. Perhaps we should unify all those responsibilities under the assertion chain?
There was a problem hiding this comment.
No need for now, makes sense and LGTM aside from the presumably accidental testnode change
…to update-bold-dec-16
…to update-bold-dec-16
This PR updates the BoLD submodule with commit d3f4d600abdacec800e9e27a429a730639233073 from the repo's
mainbranch. The PR adds support for the following features:newStakeon startup for the validator, disabled by default