Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[config change] pebble: no-sync mode and increasing level sizes #2800

Merged
merged 8 commits into from
Dec 20, 2024

Conversation

magicxyyz
Copy link
Contributor

@magicxyyz magicxyyz commented Nov 19, 2024

Resolves NIT-2952
Pulls: OffchainLabs/go-ethereum#376

This PR:

  • adds --persistent.pebble.sync-mode config option that defaults to false = pebble NO-SYNC mode
  • changes --persistent.pebble.experimental.target-file-size-equal-levels default to false to use increasing level file sizes

We follow upstream go-ethereum with switching to pebble NO-SYNC mode (ethereum/go-ethereum#29819) and using increasing level sizes (ethereum/go-ethereum#30602).

@cla-bot cla-bot bot added the s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA. label Nov 19, 2024
@magicxyyz magicxyyz changed the title pebble: NO-SYNC mode and increasing level sizes [config change] pebble: NO-SYNC mode and increasing level sizes Nov 19, 2024
@magicxyyz magicxyyz changed the title [config change] pebble: NO-SYNC mode and increasing level sizes [config change] pebble: no-sync mode and increasing level sizes Nov 19, 2024
@magicxyyz magicxyyz marked this pull request as ready for review November 19, 2024 19:42
diegoximenes
diegoximenes previously approved these changes Nov 21, 2024
Copy link
Member

@joshuacolvin0 joshuacolvin0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joshuacolvin0 joshuacolvin0 merged commit 56ff5ec into master Dec 20, 2024
16 checks passed
@joshuacolvin0 joshuacolvin0 deleted the pebble-no-sync-and-levels branch December 20, 2024 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design-approved s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants