-
Notifications
You must be signed in to change notification settings - Fork 470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[config change] pebble: no-sync mode and increasing level sizes #2800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cla-bot
bot
added
the
s
Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA.
label
Nov 19, 2024
magicxyyz
changed the title
pebble: NO-SYNC mode and increasing level sizes
[config change] pebble: NO-SYNC mode and increasing level sizes
Nov 19, 2024
magicxyyz
changed the title
[config change] pebble: NO-SYNC mode and increasing level sizes
[config change] pebble: no-sync mode and increasing level sizes
Nov 19, 2024
diegoximenes
previously approved these changes
Nov 21, 2024
joshuacolvin0
approved these changes
Dec 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
design-approved
s
Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves NIT-2952
Pulls: OffchainLabs/go-ethereum#376
This PR:
--persistent.pebble.sync-mode
config option that defaults tofalse
= pebble NO-SYNC mode--persistent.pebble.experimental.target-file-size-equal-levels
default to false to use increasing level file sizesWe follow upstream
go-ethereum
with switching to pebble NO-SYNC mode (ethereum/go-ethereum#29819) and using increasing level sizes (ethereum/go-ethereum#30602).