Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Persist Auctioneer Bid DB to S3 #2745

Merged
merged 14 commits into from
Dec 27, 2024

Conversation

ganeshvanahalli
Copy link
Contributor

@ganeshvanahalli ganeshvanahalli commented Oct 18, 2024

This PR enables auctioneer to persist validated bids, that are currently stored in a local SQLite database to AWS S3.

We introduce S3StorageService configurable via --auctioneer-server.s3-storage.* config options, that when enabled, will periodically (via --auctioneer-server.s3-storage.upload-interval) upload validated bids from local db to the configured aws S3 bucket and upon success- removes these bids from the local db.

The bids are uploaded in batches in the form of csv files compressed with gzip. The file name would be

<--s3-storage.object-prefix>validated-timeboost-bids/<year>/<month>/<day>/<fist-round-number-in-batch>-<last-round-number-in-batch>.csv.gzip

Resolves NIT-2783

@cla-bot cla-bot bot added the s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA. label Oct 18, 2024
@ganeshvanahalli ganeshvanahalli marked this pull request as ready for review October 18, 2024 13:12
Copy link
Member

@Tristan-Wilson Tristan-Wilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! A few small comments.

timeboost/db.go Show resolved Hide resolved
timeboost/s3_storage.go Outdated Show resolved Hide resolved
timeboost/s3_storage.go Outdated Show resolved Hide resolved
util/gzip_compression.go Outdated Show resolved Hide resolved
timeboost/s3_storage.go Outdated Show resolved Hide resolved
Copy link
Member

@Tristan-Wilson Tristan-Wilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I

timeboost/s3_storage.go Show resolved Hide resolved
timeboost/s3_storage.go Outdated Show resolved Hide resolved
Copy link
Member

@Tristan-Wilson Tristan-Wilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

timeboost/s3_storage.go Outdated Show resolved Hide resolved
@Tristan-Wilson Tristan-Wilson merged commit e4da075 into express-lane-timeboost Dec 27, 2024
10 checks passed
@Tristan-Wilson Tristan-Wilson deleted the persist-auctioneerbids-s3 branch December 27, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants