-
Notifications
You must be signed in to change notification settings - Fork 470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Persist Auctioneer Bid DB to S3 #2745
Persist Auctioneer Bid DB to S3 #2745
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! A few small comments.
…nt duplicate uploads
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR enables auctioneer to persist validated bids, that are currently stored in a local SQLite database to AWS S3.
We introduce S3StorageService configurable via
--auctioneer-server.s3-storage.*
config options, that when enabled, will periodically (via--auctioneer-server.s3-storage.upload-interval
) upload validated bids from local db to the configured aws S3 bucket and upon success- removes these bids from the local db.The bids are uploaded in batches in the form of csv files compressed with gzip. The file name would be
Resolves NIT-2783