Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Config Change] Start node only after the block containing rollup creation tx has been finalized (if supported) #2582

Merged
merged 6 commits into from
Dec 11, 2024

Conversation

ganeshvanahalli
Copy link
Contributor

@ganeshvanahalli ganeshvanahalli commented Aug 16, 2024

Resolves NIT-2417

Config change: add ensure-rollup-deployment key

@cla-bot cla-bot bot added the s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA. label Aug 16, 2024
@ganeshvanahalli ganeshvanahalli marked this pull request as ready for review August 16, 2024 15:33
cmd/nitro/nitro.go Outdated Show resolved Hide resolved
gligneul
gligneul previously approved these changes Aug 19, 2024
cmd/nitro/nitro.go Show resolved Hide resolved
cmd/nitro/nitro.go Show resolved Hide resolved
Copy link
Contributor

@tsahee tsahee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tsahee tsahee changed the title Start node only after the block containing rollup creation tx has been finalized (if supported) [Config Change] Start node only after the block containing rollup creation tx has been finalized (if supported) Dec 11, 2024
@tsahee tsahee enabled auto-merge December 11, 2024 00:17
@tsahee tsahee merged commit 2b3b823 into master Dec 11, 2024
15 of 16 checks passed
@tsahee tsahee deleted the waituntil-rollupcreation-isfinalized branch December 11, 2024 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design-approved s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants