Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to disable posting new batches in dataposter [NIT-2560] #2395

Merged
merged 5 commits into from
Jun 18, 2024

Conversation

anodar
Copy link
Contributor

@anodar anodar commented Jun 14, 2024

No description provided.

Copy link

cla-bot bot commented Jun 14, 2024

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: anodar.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email [email protected]
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

1 similar comment
Copy link

cla-bot bot commented Jun 14, 2024

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: anodar.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email [email protected]
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@anodar anodar changed the title Add option to disable posting new batches in dataposter Add option to disable posting new batches in dataposter [NIT-2560] Jun 14, 2024
@anodar anodar marked this pull request as ready for review June 14, 2024 14:31
Copy link

cla-bot bot commented Jun 17, 2024

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: anodar.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email [email protected]
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

amsanghi
amsanghi previously approved these changes Jun 17, 2024
PlasmaPower
PlasmaPower previously approved these changes Jun 17, 2024
Copy link
Collaborator

@PlasmaPower PlasmaPower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PlasmaPower
Copy link
Collaborator

@anodar your first commit isn't being recognized as authored by you on GitHub. The git email/name settings might've been a bit off. To get the CLA bot passing, I'd recommend squashing the commits together or otherwise amending them to override the author. You might need to amend the committer too.

@anodar anodar enabled auto-merge (squash) June 17, 2024 16:10
@anodar
Copy link
Contributor Author

anodar commented Jun 17, 2024

@cla-bot[bot] check

Copy link

cla-bot bot commented Jun 17, 2024

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: anodar.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email [email protected]
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

Copy link

cla-bot bot commented Jun 17, 2024

The cla-bot has been summoned, and re-checked this pull request!

@anodar anodar disabled auto-merge June 17, 2024 16:15
@anodar anodar dismissed stale reviews from PlasmaPower and amsanghi via 259b575 June 17, 2024 16:22
@anodar anodar force-pushed the dataposter-disable-posting-new-batches branch from 21c31a4 to 259b575 Compare June 17, 2024 16:22
@cla-bot cla-bot bot added the s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA. label Jun 17, 2024
@anodar anodar enabled auto-merge June 17, 2024 16:23
@anodar anodar requested a review from PlasmaPower June 17, 2024 16:23
@anodar anodar requested a review from amsanghi June 17, 2024 21:13
@anodar anodar merged commit 54f63eb into master Jun 18, 2024
10 of 11 checks passed
@anodar anodar deleted the dataposter-disable-posting-new-batches branch June 18, 2024 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design-approved s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants