Fetch Published Machine to test compatibility #2394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Initially, this package is able to prase the download URLs and wasm root hash from a consensus release.
The bulk of this change is wiring the Wasm.RootPath through to the right places to make sure that all of the machine locators are initialized with the same root.
cla-bot
bot
added
the
s
This keeps us from modifying the wasm root for other tests.
tsahee
previously requested changes
Jun 14, 2024
Even though the functionality that is provided thorugh this packaage could be used in produciton code. It currently isn't. Since it's only currently being used from test code, we can nest it under the util/testhelpers package.
This way, only what the funciton actually needs is passed in. Namely, the WasmModuleRoot.
This helps to ensure that the machine works with one-step-proofs.
tsahee
dismissed
their stale review
important stuff fixed.. still waiting for other reveiers
amsanghi
previously approved these changes
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fetches the latest published consensus release's
replay.wasmandmachine.wavm.brand uses them to test that the block validation works with those machines.Related to: https://linear.app/offchain-labs/issue/NIT-2571/new-arbitrator-test-compatibility-with-latest-published-machine-not