Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NIT-1307][Configuration Changes] Create a safety check that the batch poster and staker aren’t enabled with the same key #2381

Merged
merged 8 commits into from
Jun 14, 2024

Conversation

gligneul
Copy link
Contributor

No description provided.

gligneul added 3 commits June 11, 2024 16:32
This config might cause an issue when both the staker and the
batch-poster are enabled at the same time, so we decide to remove it.
The user must explicitly set each component wallet instead.
Make sure that the staker and the batch poster are using different data
poster addresses to avoid race conditions.
@cla-bot cla-bot bot added the s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA. label Jun 11, 2024
@gligneul gligneul marked this pull request as ready for review June 11, 2024 22:54
arbnode/node.go Outdated Show resolved Hide resolved
gligneul added 2 commits June 12, 2024 10:13
This message will be seen by external users, so we should avoid
mentioning the data poster.
Copy link
Contributor

@ganeshvanahalli ganeshvanahalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gligneul gligneul requested a review from amsanghi June 13, 2024 18:08
@tsahee tsahee enabled auto-merge June 14, 2024 19:11
@tsahee tsahee merged commit 52cbd28 into master Jun 14, 2024
11 checks passed
@tsahee tsahee deleted the gligneul/data-poster-safety-check branch June 14, 2024 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design-approved s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants