Pin go-ethereum with cherry-picked commit #2379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cla-bot
bot
added
the
s
diegoximenes
approved these changes
Jun 12, 2024
ganeshvanahalli
approved these changes
Jun 12, 2024
PlasmaPower
reviewed
Jun 14, 2024
| if err != nil { | ||
| return nil, fmt.Errorf("converting transaction arguments into transaction: %w", err) | ||
| } | ||
| if h := hasher.Hash(gotTx); h != hasher.Hash(signedTx) { |
There was a problem hiding this comment.
I think this should compare hash(tx) to hash(signedTx). I don't think gotTx is relevant here
There was a problem hiding this comment.
In practice this shouldn't matter though
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pins go-ethereum with changes from: OffchainLabs/go-ethereum#327, which cherry picks PR from upstream geth that implements blob txs sendTxArgs, and enables blobTx signing (ethereum/go-ethereum#28976)