Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NIT-2740] Horizontal Scaling of Validation Node #2354

Open
wants to merge 38 commits into
base: master
Choose a base branch
from
Open

[NIT-2740] Horizontal Scaling of Validation Node #2354

wants to merge 38 commits into from

Conversation

anodar
Copy link
Contributor

@anodar anodar commented May 30, 2024

No description provided.

@cla-bot cla-bot bot added the s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA. label May 30, 2024
@anodar anodar changed the base branch from master to sepolia-tooling-merge May 30, 2024 11:19
@anodar anodar mentioned this pull request May 30, 2024
Closed
@anodar anodar requested a review from tsahee May 30, 2024 15:14
tsahee
tsahee reviewed May 31, 2024
View reviewed changes
Copy link
Collaborator

@tsahee tsahee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

initial

validator/server_arb/redis/consumer.go Outdated Show resolved Hide resolved
validator/client/validation_client.go Outdated Show resolved Hide resolved
@anodar anodar requested a review from tsahee June 5, 2024 08:38
@anodar anodar marked this pull request as ready for review June 5, 2024 08:47
@anodar anodar requested a review from amsanghi June 5, 2024 08:47
@anodar anodar closed this Jun 24, 2024
@amsanghi amsanghi reopened this Jul 1, 2024
@amsanghi amsanghi changed the base branch from sepolia-tooling-merge to bold-review July 1, 2024 11:29
@amsanghi amsanghi changed the title Sepolia tooling merge redis [NIT-2645] Sepolia tooling merge redis Jul 1, 2024
@amsanghi amsanghi requested a review from rauljordan July 1, 2024 11:40
@amsanghi amsanghi changed the title [NIT-2645] Sepolia tooling merge redis [NIT-2740] Horizontal Scaling of Validation Node Aug 27, 2024
rauljordan
rauljordan reviewed Aug 28, 2024
View reviewed changes
Copy link
Contributor

@rauljordan rauljordan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lookin great so far! No comments. Just awaiting some tests so we can merge in

@PlasmaPower PlasmaPower dismissed rauljordan’s stale review December 6, 2024 20:04

The base branch was changed.

@cla-bot cla-bot
Copy link

cla-bot bot commented Dec 17, 2024

We require contributors to sign our Contributor License Agreement. In order for us to review and merge your code, please sign the linked documents below to get yourself added. https://na3.docusign.net/Member/PowerFormSigning.aspx?PowerFormId=b15c81cc-b5ea-42a6-9107-3992526f2898&env=na3&acct=6e152afc-6284-44af-a4c1-d8ef291db402&v=2

@cla-bot cla-bot bot removed the s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA. label Dec 17, 2024
eljobe
eljobe previously approved these changes Dec 17, 2024
View reviewed changes
Copy link
Member

@eljobe eljobe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tsahee
tsahee requested changes Dec 27, 2024
View reviewed changes
validator/valnode/valnode.go Outdated Show resolved Hide resolved
validator/valnode/valnode.go Outdated Show resolved Hide resolved
validator/server_arb/redis/consumer.go Outdated Show resolved Hide resolved
validator/client/validation_client.go Outdated
}

func NewExecutionClient(config rpcclient.ClientConfigFetcher, stack *node.Node) *ExecutionClient {
func NewExecutionClient(config rpcclient.ClientConfigFetcher, redisBoldValidationClientConfig *redis.ValidationClientConfig, stack *node.Node) *ExecutionClient {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

boldValclient does not need to be a field of executionclient, they are separate beings.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have made some changes for this in a9ab22e but I am not sure if its the right or intended change, please take a look once.

staker/block_validator.go Outdated Show resolved Hide resolved
@cla-bot cla-bot
Copy link

cla-bot bot commented Jan 3, 2025

We require contributors to sign our Contributor License Agreement. In order for us to review and merge your code, please sign the linked documents below to get yourself added. https://na3.docusign.net/Member/PowerFormSigning.aspx?PowerFormId=b15c81cc-b5ea-42a6-9107-3992526f2898&env=na3&acct=6e152afc-6284-44af-a4c1-d8ef291db402&v=2

@cla-bot cla-bot
Copy link

cla-bot bot commented Jan 3, 2025

We require contributors to sign our Contributor License Agreement. In order for us to review and merge your code, please sign the linked documents below to get yourself added. https://na3.docusign.net/Member/PowerFormSigning.aspx?PowerFormId=b15c81cc-b5ea-42a6-9107-3992526f2898&env=na3&acct=6e152afc-6284-44af-a4c1-d8ef291db402&v=2

@cla-bot cla-bot
Copy link

cla-bot bot commented Jan 3, 2025

We require contributors to sign our Contributor License Agreement. In order for us to review and merge your code, please sign the linked documents below to get yourself added. https://na3.docusign.net/Member/PowerFormSigning.aspx?PowerFormId=b15c81cc-b5ea-42a6-9107-3992526f2898&env=na3&acct=6e152afc-6284-44af-a4c1-d8ef291db402&v=2

@cla-bot cla-bot
Copy link

cla-bot bot commented Jan 3, 2025

We require contributors to sign our Contributor License Agreement. In order for us to review and merge your code, please sign the linked documents below to get yourself added. https://na3.docusign.net/Member/PowerFormSigning.aspx?PowerFormId=b15c81cc-b5ea-42a6-9107-3992526f2898&env=na3&acct=6e152afc-6284-44af-a4c1-d8ef291db402&v=2

@cla-bot cla-bot
Copy link

cla-bot bot commented Jan 3, 2025

We require contributors to sign our Contributor License Agreement. In order for us to review and merge your code, please sign the linked documents below to get yourself added. https://na3.docusign.net/Member/PowerFormSigning.aspx?PowerFormId=b15c81cc-b5ea-42a6-9107-3992526f2898&env=na3&acct=6e152afc-6284-44af-a4c1-d8ef291db402&v=2

@cla-bot cla-bot
Copy link

cla-bot bot commented Jan 3, 2025

We require contributors to sign our Contributor License Agreement. In order for us to review and merge your code, please sign the linked documents below to get yourself added. https://na3.docusign.net/Member/PowerFormSigning.aspx?PowerFormId=b15c81cc-b5ea-42a6-9107-3992526f2898&env=na3&acct=6e152afc-6284-44af-a4c1-d8ef291db402&v=2

@cla-bot cla-bot
Copy link

cla-bot bot commented Jan 3, 2025

We require contributors to sign our Contributor License Agreement. In order for us to review and merge your code, please sign the linked documents below to get yourself added. https://na3.docusign.net/Member/PowerFormSigning.aspx?PowerFormId=b15c81cc-b5ea-42a6-9107-3992526f2898&env=na3&acct=6e152afc-6284-44af-a4c1-d8ef291db402&v=2

@cla-bot cla-bot
Copy link

cla-bot bot commented Jan 3, 2025

We require contributors to sign our Contributor License Agreement. In order for us to review and merge your code, please sign the linked documents below to get yourself added. https://na3.docusign.net/Member/PowerFormSigning.aspx?PowerFormId=b15c81cc-b5ea-42a6-9107-3992526f2898&env=na3&acct=6e152afc-6284-44af-a4c1-d8ef291db402&v=2

@amsanghi amsanghi requested a review from tsahee January 3, 2025 15:22
@eljobe eljobe self-requested a review January 6, 2025 01:53
eljobe
eljobe approved these changes Jan 6, 2025
View reviewed changes
Copy link
Member

@eljobe eljobe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eljobe eljobe eljobe approved these changes

@rauljordan rauljordan rauljordan left review comments

@amsanghi amsanghi Awaiting requested review from amsanghi

@tsahee tsahee Awaiting requested review from tsahee

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@anodar @amsanghi @eljobe @rauljordan @tsahee