-
Notifications
You must be signed in to change notification settings - Fork 444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Read-only System Burners #179
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
@@ -85,7 +85,7 @@ func CreateTestL1BlockChain(t *testing.T, l1info info) (info, *eth.Ethereum, *no | |||
|
|||
nodeConf := ethconfig.Defaults | |||
nodeConf.NetworkId = chainConfig.ChainID.Uint64() | |||
l1Genesys = core.DeveloperGenesisBlock(0, l2pricing.PerBlockGasLimit, l1info.GetAddress("Faucet")) | |||
l1Genesys = core.DeveloperGenesisBlock(0, l2pricing.InitialPerBlockGasLimit, l1info.GetAddress("Faucet")) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noted, I only changed this because PerBlockGasLimit
is now a function, which means needing an arbosState
. We'll move to #47 when merging
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
System Burners may now be configured to be read-only, producing errors when one attempts to use them to do work that mutates state. This is useful in scenarios such as block production, where state must be read but cannot be written to without breaking tracing.
Additionally, this PR refactors internal txes to include a
Type
field