Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add script for deploying ERC20 rollups #43

Merged
merged 9 commits into from
Aug 7, 2023

Conversation

gvladika
Copy link
Contributor

@gvladika gvladika commented Jul 19, 2023

RollupCreator supports deploying both ETH and ERC20 based rollups. This commit adds script which deploys erc20 based rollups (script will deploy basic ERC20 token to be used as fee token).

@cla-bot cla-bot bot added the s label Jul 19, 2023
@gvladika gvladika requested a review from gzeoneth July 24, 2023 13:24
@gvladika gvladika requested a review from yahgwai August 4, 2023 10:36
Copy link
Member

@gzeoneth gzeoneth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Comment on lines +22 to +28
let customFeeTokenAddress = process.env.FEE_TOKEN_ADDRESS
if (!customFeeTokenAddress) {
console.log(
'FEE_TOKEN_ADDRESS env var not provided, deploying new ERC20 token'
)
customFeeTokenAddress = await deployERC20Token(deployer)
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might want to check if the supplied value is an valid address in else

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@gvladika gvladika merged commit 8d55e57 into feature-orbit-bridge Aug 7, 2023
@gvladika gvladika deleted the fee-token-deployment branch August 7, 2023 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants