Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

frame-specific crates are still in the dependency tree #82

Closed
JoshOrndorff opened this issue Jun 1, 2023 · 2 comments
Closed

frame-specific crates are still in the dependency tree #82

JoshOrndorff opened this issue Jun 1, 2023 · 2 comments

Comments

@JoshOrndorff
Copy link
Contributor 

$ cargo tree -i frame-support

frame-support v4.0.0-dev (https://github.com/paritytech/substrate.git?tag=monthly-2023-06#6ef184e3)
├── frame-system v4.0.0-dev (https://github.com/paritytech/substrate.git?tag=monthly-2023-06#6ef184e3)
│   └── pallet-transaction-payment v4.0.0-dev (https://github.com/paritytech/substrate.git?tag=monthly-2023-06#6ef184e3)
│       ├── node-template v4.0.0-dev (/home/joshy/ProgrammingProjects/tuxedo/node)
│       └── pallet-transaction-payment-rpc-runtime-api v4.0.0-dev (https://github.com/paritytech/substrate.git?tag=monthly-2023-06#6ef184e3)
│           └── pallet-transaction-payment-rpc v4.0.0-dev (https://github.com/paritytech/substrate.git?tag=monthly-2023-06#6ef184e3)
│               └── node-template v4.0.0-dev (/home/joshy/ProgrammingProjects/tuxedo/node)
└── pallet-transaction-payment v4.0.0-dev (https://github.com/paritytech/substrate.git?tag=monthly-2023-06#6ef184e3) (*)

It looks like at least one reason this happens is because we have the rpc for pallet transaction payment. We definitely don't want that, so a first step is to rip that out.
@JoshOrndorff JoshOrndorff mentioned this issue Jun 2, 2023
Merged
@JoshOrndorff
Copy link
Contributor Author

Solved in #83

@JoshOrndorff
Copy link
Contributor Author

We still depend on frame-metadata unfortunately, and I've followed up about that in paritytech/substrate#14296

@JoshOrndorff JoshOrndorff changed the title frame-support is still in the dependency tree frame-specific crates are still in the dependency tree Jun 2, 2023
@JoshOrndorff JoshOrndorff mentioned this issue Jul 3, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JoshOrndorff