Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Repost a Modal #978

Merged
merged 3 commits into from
Apr 12, 2022
Merged

Make Repost a Modal #978

merged 3 commits into from
Apr 12, 2022

Conversation

bradley-ray
Copy link
Contributor

Fixes

Issue Number:

What is the current behavior?

Currently, links to create a repost takes a user to a seperate page.

What is the new behavior?

Links to create a repost now open a modal. This made more sense considering most other actions are also done through modals. This behavior also exists in the LBRY app.

Other information

PR Checklist

Toggle...

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting)
  • Refactoring (no functional changes)
  • Documentation changes
  • Other - Please describe:

Please check all that apply to this PR using "x":

  • I have checked that this PR is not a duplicate of an existing PR (open, closed or merged)
  • I have checked that this PR does not introduce a breaking change
  • This PR introduces breaking changes and I have provided a detailed explanation below

ui/component/channelAbout/view.jsx Outdated Show resolved Hide resolved
ui/page/show/view.jsx Outdated Show resolved Hide resolved
ui/component/fileActions/view.jsx Outdated Show resolved Hide resolved
ui/component/fileActions/view.jsx Outdated Show resolved Hide resolved
@tzarebczan
Copy link
Contributor

tzarebczan commented Mar 1, 2022

<nevermind, wrong PR>

@bradley-ray
Copy link
Contributor Author

I think it should be good to go now.

@infinite-persistence
Copy link
Collaborator

infinite-persistence commented Mar 4, 2022

  • The removal in the first comment has not been reverted.

@infinite-persistence
Copy link
Collaborator

18414e2 to 233a2b2

  • Fixed remaining issues, lint, rebased and squashed to minimal commits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants