Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add example for add variable into library variable set #791

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

HuyPhanNguyen
Copy link
Collaborator

Include an example of how to add a variable to the library variable set and update the octopusdeploy_variable.owner_id to clarify the usage.

Copy link
Contributor

@domenicsim1 domenicsim1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nit change suggestions, but overall looks good.

docs/resources/variable.md Outdated Show resolved Hide resolved
@@ -145,7 +145,8 @@ func (v VariableSchema) GetResourceSchema() resourceSchema.Schema {
SchemaAttributeNames.Description: GetDescriptionResourceSchema(VariableResourceDescription),
SchemaAttributeNames.SpaceID: GetSpaceIdResourceSchema(VariableResourceDescription),
VariableSchemaAttributeNames.OwnerID: resourceSchema.StringAttribute{
Optional: true,
Description: "Owner ID for the variable(e.g., project ID or library variable set ID)",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Description: "Owner ID for the variable(e.g., project ID or library variable set ID)",
Description: "Owner ID of the variable(e.g., project ID or library variable set ID)",

@HuyPhanNguyen HuyPhanNguyen enabled auto-merge (squash) October 10, 2024 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants