feat: add kubernetes monitor sub-chart #354
Conversation
🦋 Changeset detectedLatest commit: 16a57f8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| @@ -0,0 +1,5 @@ | |||
| --- | |||
| "kubernetes-agent": minor | |||
There was a problem hiding this comment.
Kinda devils advocate, but should this be a major bump?
There was a problem hiding this comment.
It's backwards compatible, but adding new functionality, so left it as a minor according to SemVer.
There was a problem hiding this comment.
yep, happy with that. Just wanted to ask the question :)
| # Used to enable the Kubernetes Monitor | ||
| # Do not use this, as it is not supported at the moment | ||
| # @ignored | ||
| kubernetes-monitor-chart: |
There was a problem hiding this comment.
could just be kubernetesMonitor?
The fact it's a chart is kinda irrelevant for the values?
There was a problem hiding this comment.
When setting values, the sub-charts name is the root of the values for that particular chart. This allows us to expose (in future) the documentation for the subchart in our readme. If we use kubernetesMonitor, we'd need to name the chart kubernetesMonitor, which clashes with the actual image 😅
| @@ -0,0 +1,6 @@ | |||
| dependencies: | |||
| - name: kubernetes-monitor-chart | |||
| repository: oci://docker.io/octopusdeploy | |||
There was a problem hiding this comment.
Is it possible to change the repo this chart is pulled from? (say if I want to pull from Artifactory?)
There was a problem hiding this comment.
Yes, though this is only referenced once during build time, so I didn't see a reason to make it configurable. The build downloads all sub-charts (note the Chart.lock), then packages all subcharts into the helm chart as part of the packaging process.
There was a problem hiding this comment.
kk, we can always change it if we need to in the future 👍
This PR adds the kubernetes monitor to the agent as a helm dependency, and defaults the installation to
false. This allows us to (in future) allow anyone using the agent to also enable the monitor.